Change plugin and shared directory location depending on GUI build type

- If GUI is built from source:
  - Plugin Installer plugins will be installed at executable-level plugins directory
  - Config and windowState XML files will be at the same level as executable
- If GUI is installed using installers/zip:
  - Same as in v0.5.0

Author: anjaldoshi

Source/CoreServices.cpp

@@ -245,9 +245,19 @@ namespace CoreServices
 #if defined(__APPLE__)
     	File dir = File::getSpecialLocation(File::userApplicationDataDirectory).getChildFile("Application Support/open-ephys");
 #elif _WIN32
-    	File dir = File::getSpecialLocation(File::commonApplicationDataDirectory).getChildFile("Open Ephys");
+    	String appDir = File::getSpecialLocation(File::currentApplicationFile).getFullPathName();
+		File dir;
+		if(appDir.contains("plugin-GUI\\Build\\"))
+			dir = File::getSpecialLocation(File::currentApplicationFile).getParentDirectory();
+		else
+			dir = File::getSpecialLocation(File::commonApplicationDataDirectory).getChildFile("Open Ephys");
 #else
-		File dir = File::getSpecialLocation(File::userApplicationDataDirectory).getChildFile(".open-ephys");;
+		String appDir = File::getSpecialLocation(File::currentApplicationFile).getFullPathName();
+		File dir;
+		if(appDir.contains("plugin-GUI/Build/"))
+			dir = File::getSpecialLocation(File::currentApplicationFile).getParentDirectory();
+		else
+			dir = File::getSpecialLocation(File::userApplicationDataDirectory).getChildFile(".open-ephys");;
 #endif
 		if (!dir.isDirectory()) {
 			dir.createDirectory();

Source/Processors/PluginManager/PluginManager.cpp

@@ -72,19 +72,29 @@ static void errorMsg(const char *file, int line, const char *msg) {
 
 PluginManager::PluginManager()
 {
-#ifdef WIN32
+#ifdef _WIN32
+
+	String appDir = File::getSpecialLocation(File::currentApplicationFile).getFullPathName();
+
 	//Shared directory at the same level as executable
 	File sharedPath = File::getSpecialLocation(File::currentApplicationFile).getParentDirectory().getChildFile("shared");
-	SetDllDirectory(sharedPath.getFullPathName().toUTF8());
-
 	//Shared directory managed by Plugin Installer at C:/ProgramData
 	File installSharedPath = File::getSpecialLocation(File::commonApplicationDataDirectory).getChildFile("Open Ephys/shared");
-	if (!installSharedPath.isDirectory()) {
-        installSharedPath.createDirectory();
+
+	if(appDir.contains("plugin-GUI\\Build\\"))
+	{
+		SetDllDirectory(sharedPath.getFullPathName().toUTF8());
+	}
+	else
+    {
+		if (!installSharedPath.isDirectory())
+        {
+            std::cout << "Copying shared dependencies to " << installSharedPath.getFullPathName() << std::endl;
+            sharedPath.copyDirectoryTo(installSharedPath);
+        }
+        SetDllDirectory(installSharedPath.getFullPathName().toUTF8());
     }
 
-	AddDllDirectory(installSharedPath.getFullPathName().toWideCharPointer());
-	SetDefaultDllDirectories(LOAD_LIBRARY_SEARCH_DEFAULT_DIRS);
 #elif __linux__
 	File installSharedPath = File::getSpecialLocation(File::userApplicationDataDirectory).getChildFile(".open-ephys/shared");
 	if (!installSharedPath.isDirectory()) {
@@ -107,10 +117,16 @@ void PluginManager::loadAllPlugins()
     paths.add(File::getSpecialLocation(File::userApplicationDataDirectory).getChildFile("Application Support/open-ephys/plugins"));
 #elif _WIN32
 	paths.add(File::getSpecialLocation(File::currentApplicationFile).getParentDirectory().getChildFile("plugins"));
-	paths.add(File::getSpecialLocation(File::commonApplicationDataDirectory).getChildFile("Open Ephys/plugins"));
+
+    String appDir = File::getSpecialLocation(File::currentApplicationFile).getFullPathName();
+    if(!appDir.contains("plugin-GUI\\Build\\"))
+	    paths.add(File::getSpecialLocation(File::commonApplicationDataDirectory).getChildFile("Open Ephys/plugins"));
 #else
 	paths.add(File::getSpecialLocation(File::currentApplicationFile).getParentDirectory().getChildFile("plugins"));
-	paths.add(File::getSpecialLocation(File::userApplicationDataDirectory).getChildFile(".open-ephys/plugins"));	
+
+    String appDir = File::getSpecialLocation(File::currentApplicationFile).getFullPathName();
+    if(!appDir.contains("plugin-GUI/Build/"))
+	    paths.add(File::getSpecialLocation(File::userApplicationDataDirectory).getChildFile(".open-ephys/plugins"));	
 #endif
 
     for (auto &pluginPath : paths) {

Source/UI/PluginInstaller.cpp

@@ -37,17 +37,6 @@
 
 //-----------------------------------------------------------------------
 
-static inline File getPluginsLocationDirectory() {
-#if defined(__APPLE__)
-    File dir = File::getSpecialLocation(File::userApplicationDataDirectory).getChildFile("Application Support/open-ephys");
-#elif _WIN32
-    File dir = File::getSpecialLocation(File::commonApplicationDataDirectory).getChildFile("Open Ephys");
-#else
-	File dir = File::getSpecialLocation(File::userApplicationDataDirectory).getChildFile(".open-ephys");
-#endif
-    return std::move(dir);
-}
-
 static String osType;
 
 PluginInstaller::PluginInstaller(MainWindow* mainWindow)
@@ -108,12 +97,12 @@ void PluginInstaller::closeButtonPressed()
 
 void PluginInstaller::createXmlFile()
 {
-	File pluginsDir = getPluginsLocationDirectory().getChildFile("plugins");
+	File pluginsDir = CoreServices::getSavedStateDirectory().getChildFile("plugins");
     if (!pluginsDir.isDirectory())
         pluginsDir.createDirectory();
 
     String xmlFile = "plugins" + File::separatorString + "installedPlugins.xml";
-	File file = getPluginsLocationDirectory().getChildFile(xmlFile);
+	File file = CoreServices::getSavedStateDirectory().getChildFile(xmlFile);
 
 	XmlDocument doc(file);
 	std::unique_ptr<XmlElement> xml (doc.getDocumentElement());
@@ -139,7 +128,7 @@ void PluginInstaller::createXmlFile()
 
 		forEachXmlChildElement(*child, e)
 		{
-			File pluginPath = getPluginsLocationDirectory().getChildFile(baseStr + e->getAttributeValue(1));
+			File pluginPath = CoreServices::getSavedStateDirectory().getChildFile(baseStr + e->getAttributeValue(1));
 			if (!pluginPath.exists())
 				elementsToRemove.add(e);	
 		}
@@ -341,7 +330,7 @@ void PluginInstallerComponent::comboBoxChanged(ComboBox* comboBoxThatHasChanged)
 void PluginInstallerComponent::run()
 {
 	String fileStr = "plugins" + File::separatorString + "installedPlugins.xml";
-	File xmlFile = getPluginsLocationDirectory().getChildFile(fileStr);
+	File xmlFile = CoreServices::getSavedStateDirectory().getChildFile(fileStr);
 
 	XmlDocument doc(xmlFile);
 	std::unique_ptr<XmlElement> xml (doc.getDocumentElement());
@@ -665,7 +654,7 @@ bool PluginListBoxComponent::loadPluginInfo(const String& pluginName)
 
 	// If the plugin is already installed, get installed version number
 	String fileStr = "plugins" + File::separatorString + "installedPlugins.xml";
-	File xmlFile = getPluginsLocationDirectory().getChildFile(fileStr);
+	File xmlFile = CoreServices::getSavedStateDirectory().getChildFile(fileStr);
 
 	XmlDocument doc(xmlFile);
 	std::unique_ptr<XmlElement> xml (doc.getDocumentElement());
@@ -1111,7 +1100,7 @@ int PluginInfoComponent::downloadPlugin(const String& plugin, const String& vers
 			return 0;
 
 		//Get path to plugins directory
-		File pluginsPath = getPluginsLocationDirectory();
+		File pluginsPath = CoreServices::getSavedStateDirectory();
 
 		//Construct path for downloaded zip file
 		String pluginFilePath = pluginsPath.getFullPathName();