Trigger parameterValueChanged() when loading from XML

anjaldoshi · anjaldoshi · commit b90551b788db · 2023-02-13T16:16:39.000-08:00
Ensures "global" parameter value changes are relayed to the processor when loading settings from an XML file
diff --git a/Source/Processors/GenericProcessor/GenericProcessor.cpp b/Source/Processors/GenericProcessor/GenericProcessor.cpp
@@ -1734,7 +1734,11 @@ void GenericProcessor::loadFromXml()
             if (xmlNode->hasTagName("GLOBAL_PARAMETERS"))
             {
                 for (int i = 0; i < xmlNode->getNumAttributes(); i++)
-                    getParameter(xmlNode->getAttributeName(i))->fromXml(xmlNode);
+                {
+                    auto param = getParameter(xmlNode->getAttributeName(i));
+                    param->fromXml(xmlNode);
+                    parameterValueChanged(param);
+                }
             }
 
             if (xmlNode->hasTagName("STREAM") && dataStreams.size() > 0)

Original file line number	Diff line number	Diff line change
`@@ -1734,7 +1734,11 @@ void GenericProcessor::loadFromXml()`
`1734`	`1734`	`if (xmlNode->hasTagName("GLOBAL_PARAMETERS"))`
`1735`	`1735`	`{`
`1736`	`1736`	`for (int i = 0; i < xmlNode->getNumAttributes(); i++)`
`1737`		`- getParameter(xmlNode->getAttributeName(i))->fromXml(xmlNode);`
	`1737`	`+ {`
	`1738`	`+ auto param = getParameter(xmlNode->getAttributeName(i));`
	`1739`	`+ param->fromXml(xmlNode);`
	`1740`	`+ parameterValueChanged(param);`
	`1741`	`+ }`
`1738`	`1742`	`}`
`1739`	`1743`
`1740`	`1744`	`if (xmlNode->hasTagName("STREAM") && dataStreams.size() > 0)`