Skip to content

Commit c9cb133

Browse files
committed
Fix memory access violation crashes in PluginManager and PluginInstaller
1 parent 0619efd commit c9cb133

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

Source/Processors/PluginManager/PluginManager.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,8 @@ bool PluginManager::findPlugin(String name, String libName, const Array<LoadedPl
450450
{
451451
for (int i = 0; i < pluginArray.size(); i++)
452452
{
453-
if (String(pluginArray[i].name) == name)
453+
String pName = String(pluginArray[i].name);
454+
if (pName == name)
454455
{
455456
if ((libName.isEmpty()) || (libName == String(libArray[pluginArray[i].libIndex].name)))
456457
{

Source/UI/PluginInstaller.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -517,7 +517,9 @@ void PluginListBoxComponent::run()
517517
var labelData = JSON::parse(response);
518518

519519
StringArray labels;
520-
for(String label : *labelData.getProperty("labels", "NULL").getArray())
520+
auto allLabels = labelData.getProperty("labels", "NULL").getArray();
521+
522+
for(String label : *allLabels)
521523
labels.add(label);
522524

523525
if(!labels.contains("Dependency", true))

0 commit comments

Comments
 (0)