Skip to content

Commit e983f1d

Browse files
committed
Make m_triggerSelected and m_gateSelected always reflect the ComboBox id
1 parent ebe9d2b commit e983f1d

1 file changed

Lines changed: 9 additions & 16 deletions

File tree

Source/Plugins/PulsePalOutput/PulsePalOutputEditor.cpp

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,8 @@ void ChannelTriggerInterface::updateSources()
160160
EventSources s;
161161
String name;
162162
processor->clearEventSources();
163-
triggerSelector->clear();
164-
gateSelector->clear();
163+
triggerSelector->clear(dontSendNotification);
164+
gateSelector->clear(dontSendNotification);
165165
triggerSelector->addItem("Trigger", 1);
166166
gateSelector->addItem("Gate", 1);
167167
int nextItemTrig = 2;
@@ -189,17 +189,14 @@ void ChannelTriggerInterface::updateSources()
189189
if (m_triggerSelected > triggerSelector->getNumItems())
190190
{
191191
m_triggerSelected = triggerSelector->getNumItems();
192-
triggerSelector->setSelectedId(m_triggerSelected);
193192
}
194-
else
195-
triggerSelector->setSelectedId(m_triggerSelected);
193+
triggerSelector->setSelectedId(m_triggerSelected);
194+
196195
if (m_gateSelected > triggerSelector->getNumItems())
197196
{
198197
m_gateSelected = gateSelector->getNumItems();
199-
gateSelector->setSelectedId(m_gateSelected);
200198
}
201-
else
202-
gateSelector->setSelectedId(m_gateSelected);
199+
gateSelector->setSelectedId(m_gateSelected);
203200
}
204201

205202
void ChannelTriggerInterface::comboBoxChanged(ComboBox* comboBoxThatHasChanged)
@@ -208,19 +205,15 @@ void ChannelTriggerInterface::comboBoxChanged(ComboBox* comboBoxThatHasChanged)
208205
{
209206
processor->setParameter(0, channelNumber);
210207
processor->setParameter(1, (float) comboBoxThatHasChanged->getSelectedId() - 2);
211-
if (comboBoxThatHasChanged->getSelectedId() - 1 > 0)
212-
m_triggerSelected = comboBoxThatHasChanged->getSelectedId() - 1;
213-
else
214-
m_triggerSelected = 1;
208+
m_triggerSelected = comboBoxThatHasChanged->getSelectedId();
209+
215210
}
216211
else if (comboBoxThatHasChanged == gateSelector)
217212
{
218213
processor->setParameter(0, channelNumber);
219214
processor->setParameter(2, (float) comboBoxThatHasChanged->getSelectedId() - 2);
220-
if (comboBoxThatHasChanged->getSelectedId() - 1 > 0)
221-
m_gateSelected = comboBoxThatHasChanged->getSelectedId() - 1;
222-
else
223-
m_gateSelected = 1; }
215+
m_gateSelected = comboBoxThatHasChanged->getSelectedId();
216+
}
224217
}
225218

226219
int ChannelTriggerInterface::getTriggerChannel()

0 commit comments

Comments
 (0)