Fix CLI argument parsing

Author: jonluca

bin/json-schema-to-openapi-schema.js

@@ -1,7 +1,8 @@
 #!/usr/bin/env node
 'use strict';
 
-const yargs = require('yargs');
+const yargs = require('yargs/yargs');
+const { hideBin } = require('yargs/helpers');
 const converter = require('../dist/index.js').default;
 const helpText = require('./help-text.json');
 const fs = require('fs');
@@ -35,7 +36,7 @@ const readFileAsync = require('util').promisify(fs.readFile);
  */
 function parseArgs() {
 	// Configure the argument parser
-	yargs
+	const parser = yargs(hideBin(process.argv))
 		.option('d', {
 			alias: 'dereference',
 			type: 'boolean',
@@ -47,13 +48,13 @@ function parseArgs() {
 		});
 
 	// Show the version number on "--version" or "-v"
-	yargs.version().alias('v', 'version');
+	parser.version().alias('v', 'version');
 
 	// Disable the default "--help" behavior
-	yargs.help(false);
+	parser.help(false);
 
 	// Parse the command-line arguments
-	let args = yargs.argv;
+	let args = parser.parseSync();
 
 	// Normalize the parsed arguments
 	let parsed = {

test/cli.test.ts

@@ -0,0 +1,32 @@
+import { execFile } from 'node:child_process';
+import { join } from 'node:path';
+import { promisify } from 'node:util';
+import { getSchema } from './helpers';
+
+const execFileAsync = promisify(execFile);
+const repoRoot = join(__dirname, '..');
+const cliPath = join(repoRoot, 'bin', 'json-schema-to-openapi-schema.js');
+const schemaPath = join(repoRoot, 'test', 'schemas', 'basic', 'json-schema.json');
+const expectedOpenApiPath = 'basic/openapi.json';
+
+it('prints help without crashing', async ({ expect }) => {
+	const { stdout, stderr } = await execFileAsync(process.execPath, [cliPath, '-h'], {
+		cwd: repoRoot,
+	});
+
+	expect(stderr).toBe('');
+	expect(stdout).toContain('json-schema-to-openapi-schema <command> [options] <file>');
+});
+
+it('converts a schema through the CLI', async ({ expect }) => {
+	const { stdout, stderr } = await execFileAsync(
+		process.execPath,
+		[cliPath, 'convert', schemaPath],
+		{
+			cwd: repoRoot,
+		},
+	);
+
+	expect(stderr).toBe('');
+	expect(JSON.parse(stdout)).toEqual(getSchema(expectedOpenApiPath));
+});