Skip to content

Commit 08f403c

Browse files
Merge pull request #212 from openshift/fix-pf6-tooltip
COO-1685: fix: fix search tooltip and time pickers clipping
2 parents eb7d085 + e2c5fe3 commit 08f403c

2 files changed

Lines changed: 22 additions & 18 deletions

File tree

web/src/components/AdvancedSearchForm.tsx

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -263,25 +263,27 @@ export const AdvancedSearchForm: React.FC<AdvancedSearchFormProps> = ({
263263
</FormGroup>
264264

265265
<ActionGroup>
266-
<Tooltip
267-
content={
268-
!isValid
269-
? t('Fix validation errors before searching')
270-
: hasChanged
271-
? t('Update the correlation graph')
272-
: t('Correlation graph already matches search')
273-
}
274-
>
275-
<Button
276-
type="submit"
277-
variant="primary"
278-
isAriaDisabled={!hasChanged || !isValid}
279-
size="sm"
266+
<div>
267+
<Tooltip
268+
content={
269+
!isValid
270+
? t('Fix validation errors before searching')
271+
: hasChanged
272+
? t('Update the correlation graph')
273+
: t('Correlation graph already matches search')
274+
}
280275
>
281-
{t('Search')}
282-
</Button>
283-
</Tooltip>
284-
<Button variant="secondary" onClick={onCancel}>
276+
<Button
277+
type="submit"
278+
variant="primary"
279+
isAriaDisabled={!hasChanged || !isValid}
280+
size="sm"
281+
>
282+
{t('Search')}
283+
</Button>
284+
</Tooltip>
285+
</div>
286+
<Button variant="secondary" size="sm" onClick={onCancel}>
285287
{t('Cancel')}
286288
</Button>
287289
</ActionGroup>

web/src/components/DateTimePicker.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ export const DateTimePicker: React.FC<{
2121
<DatePicker
2222
value={isValidDate(date) ? yyyyMMddFormat(date) : ''}
2323
onChange={(_event, _inputDate, newDate) => onChange(copyTime(newDate, date))}
24+
appendTo={() => document.body}
2425
/>
2526
</InputGroupItem>
2627
<InputGroupItem>
@@ -30,6 +31,7 @@ export const DateTimePicker: React.FC<{
3031
if (isValid) onChange(setTime(date, hour, minute, second));
3132
}}
3233
is24Hour={true}
34+
menuAppendTo={() => document.body}
3335
width="80px"
3436
/>
3537
</InputGroupItem>

0 commit comments

Comments
 (0)