Skip to content

Commit 6ace991

Browse files
committed
HPUX-876: Map Korrel8r resources to icons
- Most icons from fontawesome or patternfly - Kubernetes ships-wheel taken from uxwing, not available in fa or pf. - Remove domain name from graph labels, redundant with icon. - Makefile: build-image TAG defaults to VERSION or 'latest' chore: NO-JIRA: Dependency clean-up Package cleanup: - Remove unused package `comment-json` and script `i18n-scripts/lexers.js` - Removed several other unused packages - see packages.json - Added .depcheckrc to give clean output from `npx depcheck` - Add TAG variable to Makefile for better control of image names. - Upgraded some packages to fix `npm audit` warnings NOTE: one audit warning is not fixed, it wants a drastic downgrade cypress@14.5.4 => 4.2.0 This looks like a mistake. Here's the notice from `npm audit` Severity: high qs's arrayLimit bypass in its bracket notation allows DoS via memory exhaustion - GHSA-6rw7-vpxm-498p fix available via `npm audit fix --force` Will install cypress@4.2.0, which is a breaking change
1 parent c946cc5 commit 6ace991

10 files changed

Lines changed: 1324 additions & 1208 deletions

File tree

Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ VERSION ?= latest
33
PLATFORMS ?= linux/arm64,linux/amd64
44
ORG ?= openshift-observability-ui
55
IMAGE ?= quay.io/${ORG}/troubleshooting-panel-console-plugin:${VERSION}
6+
TAG ?= $(VERSION)
67

78
.PHONY: test
89
test: test-frontend
@@ -56,7 +57,7 @@ install: install-frontend install-backend
5657

5758
.PHONY: build-image
5859
build-image: build-frontend test-frontend
59-
./scripts/build-image.sh
60+
TAG=$(TAG) ./scripts/build-image.sh
6061

6162
.PHONY: start-forward
6263
start-forward:

scripts/build-image.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ set -euo pipefail
44

55
PREFER_PODMAN="${PREFER_PODMAN:-1}"
66
PUSH="${PUSH:-0}"
7-
TAG="${TAG:-v0.1.0}"
7+
TAG="${TAG:-latest}"
88

99
REGISTRY_HOST=${REGISTRY_HOST:-quay.io}
1010
REGISTRY_ORG="${REGISTRY_ORG:-openshift-observability-ui}"

web/.depcheckrc

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# .depcheckrc config file for `npx depcheck`
2+
# Ignore packages not explicitly imported but still needed.
3+
# For example packages used as or via other executables, or imported via configuration files.
4+
ignores:
5+
- "@types/*"
6+
- css-loader
7+
- cypress-multi-reporters
8+
- eslint
9+
- husky
10+
- jest
11+
- jest-environment-jsdom
12+
- lint-staged
13+
- mocha-junit-reporter
14+
- mochawesome
15+
- prettier
16+
- style-loader
17+
- stylelint-config-standard
18+
- ts-loader
19+
ignore-bin-package: true

web/i18n-scripts/lexers.js

Lines changed: 0 additions & 31 deletions
This file was deleted.

0 commit comments

Comments
 (0)