Skip to content

Commit bc9313f

Browse files
Merge pull request #198 from shwetaap/COO-1391
COO-1391: Remove the managed_cluster external label within korrel8r to display the right alert graphs in ACM clusters
2 parents bd129c3 + ec4d9ec commit bc9313f

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

web/src/__tests__/alert.spec.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,11 @@ describe('AlertNode.fromURL', () => {
3131
url: 'monitoring/alertrules/12345?alertname=BarAlert',
3232
query: 'alert:alert:{"alertname":"BarAlert"}',
3333
},
34+
{
35+
url: 'monitoring/alerts/2848814126?managed_cluster=3f790d42-1f5b-4946-8bb2-ab4cfcbf255d&namespace=openshift-monitoring&severity=none&alertname=Watchdog',
36+
query:
37+
'alert:alert:{"namespace":"openshift-monitoring","severity":"none","alertname":"Watchdog"}',
38+
},
3439
])('converts $url', ({ url, query }) => {
3540
const domain = new AlertDomain(new Map([['12345', 'FooAlert']]));
3641
expect(domain.linkToQuery(new URIRef(url)).toString()).toEqual(query);

web/src/korrel8r/alert.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,5 @@ const nonLabelParams = new Set<string>([
4949
'rowFilter-alert-state',
5050
'rowFilter-alert-source',
5151
'rowFilter-alerting-rule-source',
52+
'managed_cluster',
5253
]);

0 commit comments

Comments
 (0)