Skip to content

Commit fcb6d0a

Browse files
authored
Merge pull request #1 from openshift/suggestions-pr-159
fix imports and typescript config
2 parents 68ccb5c + 909ec09 commit fcb6d0a

4 files changed

Lines changed: 12 additions & 10 deletions

File tree

web/integration-tests/plugins/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as wp from '@cypress/webpack-preprocessor';
1+
import wp from '@cypress/webpack-preprocessor';
22

33
module.exports = (on, config) => {
44
const options = {

web/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
"i18n": "i18n-scripts/build-i18n.sh && node i18n-scripts/set-english-defaults.js",
1515
"ts-node": "ts-node -O '{\"module\":\"commonjs\"}'",
1616
"lint": "eslint ./src ./integration-tests --fix && stylelint \"src/**/*.css\" --allow-empty-input --fix",
17+
"lint:tsc": "tsc --noEmit",
1718
"test:e2e": "cd ./integration-tests && cypress open --env openshift=true",
1819
"test:unit": "jest --config jest.config.js",
1920
"test:unit:watch": "jest --config jest.config.js --watch",
@@ -89,4 +90,4 @@
8990
"dependencies": {
9091
"react-router-dom-v5-compat": "^6.30.0"
9192
}
92-
}
93+
}

web/tsconfig.json

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
{
22
"compilerOptions": {
33
"baseUrl": ".",
4+
"esModuleInterop": true,
45
"module": "esnext",
56
"moduleResolution": "node",
6-
"target": "es2020",
7-
"jsx": "react",
7+
"target": "es2021",
8+
"jsx": "react-jsx",
89
"allowJs": true,
910
"strict": false,
1011
"noUnusedLocals": true,
11-
"sourceMap": true,
12-
"plugins": [{ "name": "typescript-eslint-language-service" }]
12+
"skipLibCheck": true,
13+
"resolveJsonModule": true,
14+
"allowSyntheticDefaultImports": true
1315
},
14-
"include": [
15-
"src"
16-
]
16+
"include": ["src"],
17+
"exclude": ["node_modules"]
1718
}

web/webpack.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { Configuration as WebpackConfiguration } from 'webpack';
44
import { Configuration as WebpackDevServerConfiguration } from 'webpack-dev-server';
55
import * as path from 'path';
66
import { ConsoleRemotePlugin } from '@openshift-console/dynamic-plugin-sdk-webpack';
7-
import * as CopyWebpackPlugin from 'copy-webpack-plugin';
7+
import CopyWebpackPlugin from 'copy-webpack-plugin';
88

99
interface Configuration extends WebpackConfiguration {
1010
devServer?: WebpackDevServerConfiguration;

0 commit comments

Comments
 (0)