[raspbian] Added converter/template/tests for general settings

Author: Ritwick DSouza

netjsonconfig/backends/raspbian/converters.py

@@ -3,6 +3,14 @@
 from ipaddress import IPv4Interface
 
 
+class General(BaseConverter):
+    netjson_key = 'general'
+
+    def to_intermediate(self):
+        result = []
+        general = get_copy(self.netjson, self.netjson_key)
+        result.append(general)
+        return (('general', result),)
 class Interfaces(BaseConverter):
     netjson_key = 'interfaces'
 

netjsonconfig/backends/raspbian/raspbian.py

@@ -1,4 +1,4 @@
-from .converters import Interfaces, Wireless, DnsServers, DnsSearch, Ntp
+from .converters import General, Interfaces, Wireless, DnsServers, DnsSearch, Ntp
 from .renderers import Raspbian
 from ..base.backend import BaseBackend
 from .schema import schema
@@ -11,6 +11,7 @@ class Raspbian(BaseBackend):
     schema = schema
     env_path = 'netjsonconfig.backends.raspbian'
     converters = [
+        General,
         Interfaces,
         Wireless,
         DnsServers,

netjsonconfig/backends/raspbian/templates/raspbian.jinja2

@@ -1,4 +1,26 @@
 {% for i, j in data.items() %}
+{% if i|string() == 'general' %}
+{% for general in j %}
+{% if general.get('hostname') %}
+config: /etc/hostname
+{{ general.get('hostname') }}
+
+{% endif %}
+{% endfor %}
+{% endif %}
+{% endfor %}
+{% for i, j  in data.items() %}
+{% if i|string() == 'general' %}
+{% for general in j %}
+{% if general.get('timezone') %}
+run commands:
+$ timedatectl set-timezone {{ general.get('timezone') }}
+
+{% endif %}
+{% endfor %}
+{% endif %}
+{% endfor%}
+{% for i, j in data.items() %}
 {% if i|string() == 'interfaces' %}
 {% for interface in j %}
 {% if interface.get('iftype') == 'wireless' %}

tests/raspbian/test_system.py

@@ -6,6 +6,26 @@
 
 class TestSystemRender(unittest.TestCase, _TabsMixin):
 
+    def test_general(self):
+        o = Raspbian({
+            "general": {
+                "hostname": "test-system",
+                "timezone": "Europe/Rome",
+                "custom_setting": True,
+                "empty_setting1": None,
+                "empty_setting2": ""
+            }
+        })
+
+        expected = '''config: /etc/hostname
+test-system
+
+run commands:
+$ timedatectl set-timezone Europe/Rome
+
+'''
+        self.assertEqual(o.render(), expected)
+
     def test_ntp(self):
         o = Raspbian({
             "ntp": {