[fix] Fixed UCI format backward compatibility with OpenWISP 1

This fix is needed to allow workarounds in the code of
OpenWISP-Firmware to keep working also with OpenWISP 2.

Author: nemesifier

netjsonconfig/backends/openwisp/openwisp.py

@@ -3,6 +3,7 @@
 from jinja2 import Environment, PackageLoader
 
 from ..openwrt.openwrt import OpenWrt
+from .renderer import OpenWrtRenderer
 from .schema import schema
 
 
@@ -12,6 +13,7 @@ class OpenWisp(OpenWrt):
     """
 
     schema = schema
+    renderer = OpenWrtRenderer
 
     def validate(self):
         self._sanitize_radios()

netjsonconfig/backends/openwisp/renderer.py

@@ -0,0 +1,24 @@
+from ..openwrt.renderer import OpenWrtRenderer as BaseRenderer
+
+
+class OpenWrtRenderer(BaseRenderer):
+    """
+    OpenWRT Renderer for OpenWISP 1.x backend
+
+    It uses a slightly different template
+    than the default OpenWRT renderer in order
+    to provide backward compatibility with the
+    format that was generated by OpenWISP Manager.
+
+    E.g.:
+
+    # OpenWISP Manager:
+    config 'system' 'system'
+        option 'hostname' 'openwisp-test'
+
+    # standard OpenWRT conf generated by netjsonconfig:
+    config system 'system'
+        option hostname 'openwisp-test'
+    """
+
+    pass

netjsonconfig/backends/openwisp/templates/openwrt.jinja2

@@ -0,0 +1,20 @@
+{% for package, config_blocks in data.items() %}
+    package {{ package }}
+
+    {% for config in config_blocks %}
+        config '{{ config['.type'] }}' '{{ config['.name'] }}'
+        {% for key, value in config.items() %}
+            {% if value not in ['', None] and not key.startswith('.') %}
+                {% if value is not string and value is iterable %}
+                    {% for list_value in value %}
+                        list '{{ key }}' '{{ list_value }}'
+                    {% endfor %}
+                {% else %}
+                    option '{{ key }}' '{{ value }}'
+                {% endif %}
+            {% endif %}
+        {% endfor %}
+
+    {% endfor %}
+
+{% endfor %}

tests/openwisp/test_backend.py

@@ -111,8 +111,8 @@ def test_uci(self):
         expected = self._tabs(
             """package system
 
-config system 'system'
-    option hostname 'openwisp-test'
+config 'system' 'system'
+    option 'hostname' 'openwisp-test'
 """
         )
         self.assertEqual(contents, expected)
@@ -182,7 +182,7 @@ def test_double_generation(self):
     def test_wireless_radio_disabled_0(self):
         o = OpenWisp({'radios': self.config['radios']})
         output = o.render()
-        self.assertIn("option disabled '0'", output)
+        self.assertIn("option 'disabled' '0'", output)
 
     def test_tc_script(self):
         config = deepcopy(self.config)