[fix] Avoid replcing the substring having TRUE/FALSE

Author: Viscous106

netjsonconfig/backends/openwrt/renderer.py

@@ -1,5 +1,3 @@
-import re
-
 from ..base.renderer import BaseRenderer
 
 
@@ -19,8 +17,7 @@ def cleanup(self, output):
             .replace("\nlist", "\n\tlist")
         )
         # convert True to 1 and False to 0 (exact match only, not substrings)
-        output = re.sub(r"'True'", "'1'", output)
-        output = re.sub(r"'False'", "'0'", output)
+        output = output.replace("'True'", "'1'").replace("'False'", "'0'")
         # max 2 consecutive \n delimiters
         output = output.replace("\n\n\n", "\n\n")
         # if output is present

tests/openwrt/test_wireless.py

@@ -77,6 +77,27 @@ def test_render_wifi_issue_250_false_ssid(self):
         expected_uci = self._wifi_uci.replace("'MyWifiAP'", "'FalseGait Living Guest'")
         self.assertEqual(o.render(), self._tabs(expected_uci))
 
+    def test_render_wifi_issue_250_mid_word_true_ssid(self):
+        netjson = deepcopy(self._wifi_netjson)
+        netjson["interfaces"][0]["wireless"]["ssid"] = "MyTrueNetwork"
+        o = OpenWrt(netjson)
+        expected_uci = self._wifi_uci.replace("'MyWifiAP'", "'MyTrueNetwork'")
+        self.assertEqual(o.render(), self._tabs(expected_uci))
+
+    def test_render_wifi_issue_250_exact_true_ssid(self):
+        netjson = deepcopy(self._wifi_netjson)
+        netjson["interfaces"][0]["wireless"]["ssid"] = "True"
+        o = OpenWrt(netjson)
+        expected_uci = self._wifi_uci.replace("'MyWifiAP'", "'1'")
+        self.assertEqual(o.render(), self._tabs(expected_uci))
+
+    def test_render_wifi_issue_250_exact_false_ssid(self):
+        netjson = deepcopy(self._wifi_netjson)
+        netjson["interfaces"][0]["wireless"]["ssid"] = "False"
+        o = OpenWrt(netjson)
+        expected_uci = self._wifi_uci.replace("'MyWifiAP'", "'0'")
+        self.assertEqual(o.render(), self._tabs(expected_uci))
+
     def test_parse_wifi_interface(self):
         o = OpenWrt(native=self._wifi_uci)
         self.assertDictEqual(o.config, self._wifi_netjson)