Skip to content

Commit f15cf3c

Browse files
[openwrt] Fix firewall defaults parser
The defaults section can be empty, so when parsing UCI to netjson it is necessary to remove the defaults section if it is empty.
1 parent bc7dc88 commit f15cf3c

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

netjsonconfig/backends/openwrt/converters/firewall.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,9 @@ def to_netjson_loop(self, block, result, index):
155155

156156
if _type == "defaults":
157157
defaults = self.__netjson_defaults(block)
158-
result["firewall"].setdefault("defaults", {})
159-
result["firewall"]["defaults"].update(defaults)
158+
if defaults: # note: default section can be empty
159+
result["firewall"].setdefault("defaults", {})
160+
result["firewall"]["defaults"].update(defaults)
160161
if _type == "rule":
161162
rule = self.__netjson_rule(block)
162163
result["firewall"].setdefault("rules", [])

0 commit comments

Comments
 (0)