[change] Remove unneeded ssl package implementation definitions

Which ssl implementation is used by the openwisp-config agent is decided
in the curl package. The openwisp-agent is not compiled servivce.
Therefore, the division into different packages is not
necessary. This commit removes all ssl package versions. There is now
only one openwisp-config package.

Other PRs related to this work:

- openwrt/luci#5471
- openwisp/openwrt-openwisp-monitoring#78

Signed-off-by: Florian Eckert <fe@dev.tdt.de>

Author: feckert

README.rst

@@ -45,8 +45,7 @@ Then install one of the `latest builds <http://downloads.openwisp.io/openwisp-co
 
     opkg install <URL>
 
-Where ``<URL>`` is the URL of the image that is suitable for your case
-(we suggest ``openssl`` or alternatively ``mbedtls``).
+Where ``<URL>`` is the URL of the precompiled openwisp-config package.
 
 For a list of the latest built images, take a look at `downloads.openwisp.io/openwisp-config/
 <http://downloads.openwisp.io/openwisp-config/>`_.
@@ -296,20 +295,13 @@ Path to an executable script that will be called after the registration is compl
 Compiling openwisp-config
 -------------------------
 
-There are 4 variants of *openwisp-config*:
-
-- **openwisp-config-openssl**: depends on *ca-certificates* and *libopenssl*
-- **openwisp-config-mbedtls**: depends on *ca-certificates* and *libmbedtls*
-- **openwisp-config-wolfssl**: depends on *ca-certificates* and *libwolfssl*
-- **openwisp-config-nossl**: doesn't depend on any SSL library and doesn't install trusted CA certificates
-
-The following procedure illustrates how to compile all the *openwisp-config* variants and their dependencies:
+The following procedure illustrates how to compile *openwisp-config* and its dependencies:
 
 .. code-block:: shell
 
     git clone https://github.com/openwrt/openwrt.git openwrt
     cd openwrt
-    git checkout openwrt-19.07
+    git checkout <openwrt-branch>
 
     # configure feeds
     echo "src-git openwisp https://github.com/openwisp/openwisp-config.git" > feeds.conf
@@ -319,23 +311,20 @@ The following procedure illustrates how to compile all the *openwisp-config* var
     # any arch/target is fine because the package is architecture indipendent
     arch="ar71xx"
     echo "CONFIG_TARGET_$arch=y" > .config;
-    echo "CONFIG_PACKAGE_openwisp-config-openssl=y" >> .config
-    echo "CONFIG_PACKAGE_openwisp-config-mbedtls=y" >> .config
-    echo "CONFIG_PACKAGE_openwisp-config-wolfssl=y" >> .config
-    echo "CONFIG_PACKAGE_openwisp-config-nossl=y" >> .config
+    echo "CONFIG_PACKAGE_openwisp-config=y" >> .config
     make defconfig
     make tools/install
     make toolchain/install
     make package/openwisp-config/compile
 
 Alternatively, you can configure your build interactively with ``make menuconfig``, in this case
-you will need to select the *openwisp-config* variant by going to ``Administration > openwisp``:
+you will need to select *openwisp-config* by going to ``Administration > openwisp``:
 
 .. code-block:: shell
 
     git clone https://github.com/openwrt/openwrt.git openwrt
     cd openwrt
-    git checkout openwrt-19.07
+    git checkout <openwrt-branch>
 
     # configure feeds
     echo "src-git openwisp https://github.com/openwisp/openwisp-config.git" > feeds.conf
@@ -358,14 +347,14 @@ each new device, you should switch to using a custom OpenWRT firmware image that
   hence saving extra time and effort to register each device on the controller app
 * if you happen to reset the firmware to initial settings, these precompiled settings will be restored as well
 
-The following procedure illustrates how to compile a custom `OpenWRT 19.07 <https://openwrt.org/>`_
+The following procedure illustrates how to compile a custom `OpenWRT <https://openwrt.org/>`_
 image with a precompiled minimal ``/etc/config/openwisp`` configuration file:
 
 .. code-block:: shell
 
     git clone https://github.com/openwrt/openwrt.git openwrt
     cd openwrt
-    git checkout openwrt-19.07
+    git checkout <openwrt-branch>
 
     # include precompiled file
     mkdir -p files/etc/config
@@ -384,8 +373,7 @@ image with a precompiled minimal ``/etc/config/openwisp`` configuration file:
     # replace with your desired arch target
     arch="ar71xx"
     echo "CONFIG_TARGET_$arch=y" > .config
-    echo "CONFIG_PACKAGE_openwisp-config-openssl=y" >> .config
-    echo "CONFIG_LIBCURL_OPENSSL=y" >> .config
+    echo "CONFIG_PACKAGE_openwisp-config=y" >> .config
     make defconfig
     # compile with verbose output
     make -j1 V=s

openwisp-config/Makefile

@@ -10,40 +10,28 @@ PKG_VERSION:=$(shell cat ../VERSION)
 PKG_RELEASE:=1
 PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)-$(BUILD_VARIANT)/$(PKG_SOURCE_SUBDIR)
 PKG_LICENSE:=GPL-3.0
+PKG_MAINTAINER:=Federico Capoano <f.capoano@openwisp.io>
 
 include $(INCLUDE_DIR)/package.mk
 
-define Package/openwisp-config/default
-	TITLE:=Remote configuration management agent ($(2) variant)
+define Package/openwisp-config
+	TITLE:=Remote configuration management agent
 	CATEGORY:=Administration
 	SECTION:=admin
 	SUBMENU:=openwisp
-	DEPENDS:=+curl +lua +libuci-lua +luafilesystem +luci-lib-nixio $(3)
-	VARIANT:=$(1)
+	DEPENDS:=+curl +lua +libuci-lua +luafilesystem +luci-lib-nixio +ca-certificates
 	PKGARCH:=all
-	MAINTAINER:=Federico Capoano <f.capoano@openwisp.io>
 	URL:=http://openwisp.org
 endef
 
-Package/openwisp-config-openssl=$(call Package/openwisp-config/default,openssl,OpenSSL,+ca-certificates +libopenssl)
-Package/openwisp-config-mbedtls=$(call Package/openwisp-config/default,mbedtls,mbedTLS,+ca-certificates +libmbedtls)
-Package/openwisp-config-wolfssl=$(call Package/openwisp-config/default,wolfssl,WolfSSL,+ca-certificates +libwolfssl)
-Package/openwisp-config-nossl=$(call Package/openwisp-config/default,nossl,No SSL)
-
 define Build/Compile
 endef
 
-define Package/openwisp-config-$(BUILD_VARIANT)/conffiles
+define Package/openwisp-config/conffiles
 /etc/config/openwisp
 endef
 
-CONFIG_OPENWISP_UCI:=ssl
-
-ifeq ($(BUILD_VARIANT),nossl)
-    CONFIG_OPENWISP_UCI:=nossl
-endif
-
-define Package/openwisp-config-$(BUILD_VARIANT)/install
+define Package/openwisp-config/install
 	$(INSTALL_DIR) \
 		$(1)/usr/sbin \
 		$(1)/etc/init.d \
@@ -59,7 +47,7 @@ define Package/openwisp-config-$(BUILD_VARIANT)/install
 		files/openwisp.init \
 		$(1)/etc/init.d/openwisp_config
 
-	$(INSTALL_CONF) files/openwisp-$(CONFIG_OPENWISP_UCI).config \
+	$(INSTALL_CONF) files/openwisp.config \
 		$(1)/etc/config/openwisp
 
 	$(INSTALL_BIN) \
@@ -101,7 +89,4 @@ define Package/openwisp-config-$(BUILD_VARIANT)/install
 	$(CP) ../VERSION $(1)/etc/openwisp/
 endef
 
-$(eval $(call BuildPackage,openwisp-config-openssl))
-$(eval $(call BuildPackage,openwisp-config-mbedtls))
-$(eval $(call BuildPackage,openwisp-config-wolfssl))
-$(eval $(call BuildPackage,openwisp-config-nossl))
+$(eval $(call BuildPackage,openwisp-config))

openwisp-config/files/openwisp-nossl.config

@@ -42,13 +42,7 @@ sed -i '/telephony/d' feeds.conf
 sed -i '/routing/d' feeds.conf
 ./scripts/feeds update -a
 ./scripts/feeds install -a
-
-{
-  echo "CONFIG_PACKAGE_openwisp-config-openssl=y"
-  echo "CONFIG_PACKAGE_openwisp-config-mbedtls=y"
-  echo "CONFIG_PACKAGE_openwisp-config-wolfssl=y"
-  echo "CONFIG_PACKAGE_openwisp-config-nossl=y"
-} >>.config
+echo "CONFIG_PACKAGE_openwisp-config=y" >>.config
 make defconfig
 
 if [ ! "$CI_CACHE" ]; then