[chores:fix] Add TestMigrationGraphIntegrity to render all project_states

Co-authored-by: Alexandre Vincent <alexandre.vincent@stellar.tc>

Author: asmodehn

openwisp_controller/connection/migrations/0001_initial.py

@@ -23,7 +23,10 @@ class Migration(migrations.Migration):
         swapper.dependency(
             *swapper.split(settings.AUTH_USER_MODEL), version="0004_default_groups"
         ),
-        swapper.dependency("config", "Device"),
+        swapper.dependency(
+            *swapper.split(settings.CONFIG_DEVICE_MODEL),
+            version="0004_add_device_model"
+        ),
     ]
 
     operations = [

openwisp_controller/geo/migrations/0001_initial.py

@@ -21,7 +21,10 @@ class Migration(migrations.Migration):
         swapper.dependency(
             *swapper.split(settings.AUTH_USER_MODEL), version="0004_default_groups"
         ),
-        swapper.dependency("config", "Device"),
+        swapper.dependency(
+            *swapper.split(settings.CONFIG_DEVICE_MODEL),
+            version="0004_add_device_model"
+        ),
     ]
 
     operations = [

openwisp_controller/tests/test_migrationgraph.py

@@ -0,0 +1,32 @@
+from __future__ import annotations
+
+from django.db.migrations.loader import MigrationLoader
+from django.test import SimpleTestCase, tag
+
+
+@tag("slow")
+class TestMigrationGraphIntegrity(SimpleTestCase):
+    def test_all_migration_states_render_apps(self) -> None:
+        """
+        Fail fast if any migration target produces an invalid historical StateApps.
+
+        This catches missing dependencies / broken swappable references that only
+        show up when Django renders historical models.
+
+        Note : issues in third-party dependency migrations
+        will also be detected.
+        """
+        loader = MigrationLoader(None, ignore_no_migrations=True)
+
+        failures: list[str] = []
+        for key in sorted(loader.graph.nodes.keys()):
+            try:
+                state = loader.project_state([key])
+                _ = state.apps  # triggers StateApps rendering
+            except (LookupError, ValueError, AttributeError, TypeError) as e:
+                failures.append(f"{key[0]}.{key[1]} -> {type(e).__name__}: {e}")
+
+        if failures:
+            self.fail(
+                "Some migration states cannot be rendered:\n" + "\n".join(failures)
+            )

runtests.py

@@ -46,6 +46,7 @@ def run_tests(extra_args, settings_module, test_app):
     else:
         test_app = "openwisp2"
         app_dir = "tests/openwisp2/"
+        args += ["--exclude-tag", "slow"]
     # Run Django tests
     django_tests = run_tests(args, "openwisp2.settings", test_app)
     # Run pytest tests