[fix] Fixed Device._has_group() wrongly returning True

Author: nemesifier

openwisp_controller/config/base/device.py

@@ -128,7 +128,7 @@ def _has_config(self):
         return hasattr(self, 'config')
 
     def _has_group(self):
-        return hasattr(self, 'group')
+        return hasattr(self, 'group') and self.group is not None
 
     def _has_organization__config_settings(self):
         return hasattr(self, 'organization') and hasattr(

openwisp_controller/config/tests/test_device.py

@@ -564,3 +564,11 @@ def test_device_org_change_limit_check(self):
                 f' for organization {org2}.'
             ),
         )
+
+    def test_has_methods(self):
+        device = self._create_device(
+            name='11:22:33:44:55:66',
+            mac_address='11:22:33:44:55:66',
+            organization=self._get_org(),
+        )
+        self.assertFalse(device._has_group())