[chores] Removed old, deprecated code

Author: Viscous106

openwisp_controller/config/base/config.py

@@ -30,15 +30,6 @@
 logger = logging.getLogger(__name__)
 
 
-def get_cached_checksum_args_rewrite(config):
-    """
-    DEPRECATED: Use get_cached_args_rewrite instead.
-
-    TODO: Remove this in 1.2.0 release.
-    """
-    return get_cached_args_rewrite(config)
-
-
 class TemplatesThrough(object):
     """
     Improves string representation of m2m relationship objects

openwisp_controller/config/controller/views.py

@@ -251,16 +251,12 @@ def post(self, request, *args, **kwargs):
         config = device.config
         # ensure request is well formed and authorized
         allowed_status = [choices[0] for choices in config.STATUS]
-        allowed_status.append("running")  # backward compatibility
         required_params = [("key", device.key), ("status", allowed_status)]
         for key, value in required_params:
             bad_response = forbid_unallowed(request, "POST", key, value)
             if bad_response:
                 return bad_response
         status = request.POST.get("status")
-        # mantain backward compatibility with old agents
-        # ("running" was changed to "applied")
-        status = status if status != "running" else "applied"
         # If the Config.status is "deactivating", then set the
         # status to "deactivated". This will stop the device
         # from receiving new configurations.

openwisp_controller/config/tasks.py

@@ -198,13 +198,3 @@ def invalidate_controller_views_cache(organization_id):
         Vpn.objects.filter(organization_id=organization_id).only("id").iterator()
     ):
         GetVpnView.invalidate_get_vpn_cache(vpn)
-
-
-@shared_task(base=OpenwispCeleryTask)
-def invalidate_device_checksum_view_cache(organization_id):
-    """
-    DEPRECATED: Use invalidate_controller_views_cache instead.
-
-    TODO: Remove this in 1.2.0 release.
-    """
-    return invalidate_controller_views_cache(organization_id)

openwisp_controller/config/tests/test_controller.py

@@ -913,20 +913,6 @@ def test_device_registration_hostname_comparison_case_insensitive(
         self.assertEqual(device.name, name)
         mocked_method.assert_not_called()
 
-    def test_device_report_status_running(self):
-        """
-        maintained for backward compatibility
-        # TODO: remove in stable version 1.0
-        """
-        d = self._create_device_config()
-        response = self.client.post(
-            reverse("controller:device_report_status", args=[d.pk]),
-            {"key": d.key, "status": "running"},
-        )
-        self._check_header(response)
-        d.config.refresh_from_db()
-        self.assertEqual(d.config.status, "applied")
-
     def test_device_report_status_applied(self):
         d = self._create_device_config()
         with catch_signal(config_status_changed) as handler: