Skip to content

Commit 2d28f48

Browse files
Remove outdated BOM warning from dependencyManagement (#286)
flattenMode=ossrh strips dependencyManagement from published poms, so end users never inherit BOMs declared here. See: https://github.com/mojohaus/flatten-maven-plugin/blob/master/src/main/java/org/codehaus/mojo/flatten/FlattenMode.java Signed-off-by: Adrian Cole <adrian@tetrate.io> Signed-off-by: Adrian Cole <adrian@tetrate.io>
1 parent 0631edd commit 2d28f48

1 file changed

Lines changed: 0 additions & 10 deletions

File tree

pom.xml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -142,16 +142,6 @@
142142
<url>https://github.com/openzipkin/zipkin-reporter-java/issues</url>
143143
</issueManagement>
144144

145-
<dependencyManagement>
146-
<!-- Be careful here, especially to not import BOMs as io.zipkin.reporter2:zipkin-reporter and
147-
zipkin-reporter-brave have this parent.
148-
149-
For example, if you imported Netty's BOM here, using Brave would also download that BOM as
150-
it depends indirectly on io.zipkin.reporter2:zipkin-reporter-brave. As Brave itself is
151-
indirectly used, this can be extremely confusing when people are troubleshooting library
152-
version assignments. -->
153-
</dependencyManagement>
154-
155145
<dependencies>
156146
<!-- Do not add compile dependencies here. This can cause problems for libraries that depend on
157147
io.zipkin.reporter2:zipkin-reporter or zipkin-reporter-brave difficult to unravel. -->

0 commit comments

Comments
 (0)