Run a separate pass to determine whether input needs to be changed

Author: dwalluck

src/main/java/com/github/packageurl/PackageURL.java

@@ -35,6 +35,7 @@
 import java.util.function.IntPredicate;
 import java.util.regex.Pattern;
 import java.util.stream.Collectors;
+import java.util.stream.IntStream;
 
 /**
  * <p>Package-URL (aka purl) is a "mostly universal" URL to describe a package. A purl is a URL composed of seven components:</p>
@@ -475,21 +476,25 @@ private static String uriEncode(String source, Charset charset) {
             return source;
         }
 
-        boolean changed = false;
-        StringBuilder builder = new StringBuilder(source.length());
         byte[] bytes = source.getBytes(charset);
 
+        if (IntStream.range(0, bytes.length).allMatch(i -> isUnreserved(bytes[i]))) {
+            return source;
+        }
+
+        StringBuilder builder = new StringBuilder(source.length());
+
         for (byte b : bytes) {
             if (isUnreserved(b)) {
                 builder.append((char) b);
             } else {
                 builder.append('%');
                 builder.append(Character.toUpperCase(Character.forDigit((b >> 4) & 0xF, 16)));
                 builder.append(Character.toUpperCase(Character.forDigit(b & 0xF, 16)));
-                changed = true;
             }
         }
-        return changed ? builder.toString() : source;
+
+        return builder.toString();
     }
 
     private static boolean isUnreserved(int c) {
@@ -567,7 +572,10 @@ public static String uriDecode(String source) {
             return source;
         }
 
-        boolean changed = false;
+        if (source.indexOf('%') == -1) {
+            return source;
+        }
+
         byte[] bytes = source.getBytes(StandardCharsets.UTF_8);
         int length = bytes.length;
         ByteArrayOutputStream buffer = new ByteArrayOutputStream(length);
@@ -583,13 +591,12 @@ public static String uriDecode(String source) {
                     int b1 = Character.digit(bytes[++i], 16);
                     int b2 = Character.digit(bytes[++i], 16);
                     buffer.write((char) ((b1 << 4) + b2));
-                    changed = true;
             } else {
                 buffer.write(b);
             }
         }
 
-        return changed ? new String(buffer.toByteArray(), StandardCharsets.UTF_8) : source;
+        return new String(buffer.toByteArray(), StandardCharsets.UTF_8);
     }
 
     /**