Excavator: Remove calls to deprecated APIs (#1483)

Author: svc-excavator-bot

errors/src/test/java/com/palantir/conjure/java/api/errors/RemoteExceptionTest.java

@@ -24,7 +24,6 @@
 
 public final class RemoteExceptionTest {
 
-    @SuppressWarnings("for-rollout:deprecation")
     @Test
     public void testJavaSerialization() {
         // With explicit error instance
@@ -35,7 +34,7 @@ public void testJavaSerialization() {
                 .build();
         RemoteException expected = new RemoteException(error, 500);
         RemoteException actual = SerializationUtils.deserialize(SerializationUtils.serialize(expected));
-        assertThat(actual).isEqualToComparingFieldByField(expected);
+        assertThat(actual).usingRecursiveComparison().isEqualTo(expected);
 
         // Without error instance
         error = new SerializableError.Builder()
@@ -44,7 +43,7 @@ public void testJavaSerialization() {
                 .build();
         expected = new RemoteException(error, 500);
         actual = SerializationUtils.deserialize(SerializationUtils.serialize(expected));
-        assertThat(actual).isEqualToComparingFieldByField(expected);
+        assertThat(actual).usingRecursiveComparison().isEqualTo(expected);
     }
 
     @Test

test-utils/src/main/java/com/palantir/conjure/java/api/testing/Assertions.java

@@ -19,11 +19,10 @@
 import com.palantir.conjure.java.api.errors.QosException;
 import com.palantir.conjure.java.api.errors.RemoteException;
 import com.palantir.conjure.java.api.errors.ServiceException;
+import org.assertj.core.annotation.CanIgnoreReturnValue;
+import org.assertj.core.annotation.CheckReturnValue;
 import org.assertj.core.api.ThrowableAssert.ThrowingCallable;
-import org.assertj.core.util.CanIgnoreReturnValue;
-import org.assertj.core.util.CheckReturnValue;
 
-@SuppressWarnings("for-rollout:deprecation")
 @CheckReturnValue
 public class Assertions extends org.assertj.core.api.Assertions {
 
@@ -41,19 +40,16 @@ public static QosExceptionAssert assertThat(QosException actual) {
         return new QosExceptionAssert(actual);
     }
 
-    @SuppressWarnings("for-rollout:deprecation")
     @CanIgnoreReturnValue
     public static ServiceExceptionAssert assertThatServiceExceptionThrownBy(ThrowingCallable shouldRaiseThrowable) {
         return assertThatThrownBy(shouldRaiseThrowable).asInstanceOf(ServiceExceptionAssert.instanceOfAssertFactory());
     }
 
-    @SuppressWarnings("for-rollout:deprecation")
     @CanIgnoreReturnValue
     public static RemoteExceptionAssert assertThatRemoteExceptionThrownBy(ThrowingCallable shouldRaiseThrowable) {
         return assertThatThrownBy(shouldRaiseThrowable).asInstanceOf(RemoteExceptionAssert.instanceOfAssertFactory());
     }
 
-    @SuppressWarnings("for-rollout:deprecation")
     @CanIgnoreReturnValue
     public static QosExceptionAssert assertThatQosExceptionThrownBy(ThrowingCallable shouldRaiseThrowable) {
         return assertThatThrownBy(shouldRaiseThrowable).asInstanceOf(QosExceptionAssert.instanceOfAssertFactory());