check

Author: Henry Harris

errors/src/main/java/com/palantir/conjure/java/api/errors/BaseServiceException.java

@@ -22,14 +22,14 @@
 
 public abstract class BaseServiceException extends RuntimeException {
 
-    protected final ErrorType errorType;
+    private final ErrorType errorType;
 
-    protected final List<Arg<?>> args; // unmodifiable
+    private final List<Arg<?>> args; // unmodifiable
 
-    protected final String errorInstanceId;
+    private final String errorInstanceId;
 
-    protected final String unsafeMessage;
-    protected final String noArgsMessage;
+    private final String unsafeMessage;
+    private final String noArgsMessage;
 
     /**
      * Creates a new exception for the given error. All {@link com.palantir.logsafe.Arg parameters} are propagated to
@@ -64,29 +64,29 @@ public abstract class BaseServiceException extends RuntimeException {
     /**
      * The {@link ErrorType} that gave rise to this exception.
      */
-    public ErrorType getErrorType() {
+    public final ErrorType getErrorType() {
         return errorType;
     }
 
     /**
      * A unique identifier for (this instance of) this error.
      */
-    public String getErrorInstanceId() {
+    public final String getErrorInstanceId() {
         return errorInstanceId;
     }
 
     @Override
-    public String getMessage() {
+    public final String getMessage() {
         // Including all args here since any logger not configured with safe-logging will log this message.
         return unsafeMessage;
     }
 
-    public String getLogMessage() {
+    public final String getLogMessage() {
         // Not returning safe args here since the safe-logging framework will log this message + args explicitly.
         return noArgsMessage;
     }
 
-    public List<Arg<?>> getArgs() {
+    public final List<Arg<?>> getArgs() {
         return args;
     }
 }

errors/src/main/java/com/palantir/conjure/java/api/errors/EndpointServiceException.java

@@ -24,7 +24,7 @@
  * This is identical to ServiceException, but is used in Conjure-generated code to indicate that an exception was thrown
  * from a service endpoint.
  */
-public class EndpointServiceException extends BaseServiceException implements SafeLoggable {
+public final class EndpointServiceException extends BaseServiceException implements SafeLoggable {
 
     private static final String EXCEPTION_NAME = "EndpointServiceException";
 

errors/src/main/java/com/palantir/conjure/java/api/errors/SerializableError.java

@@ -50,8 +50,8 @@ public abstract class SerializableError implements Serializable {
     /**
      * A fixed code word identifying the type of error. For errors generated from {@link ServiceException}, this
      * corresponds to the {@link ErrorType#code} and is part of the service's API surface. Clients are given access to
-     * the server-side error code via {@link RemoteException#getError} and typically switch&dispatch on the error code
-     * and/or name.
+     * the server-side error code via {@link RemoteException#getError} and typically switch and dispatch on the error
+     * code and/or name.
      */
     @JsonProperty("errorCode")
     @Value.Default
@@ -62,9 +62,9 @@ public String errorCode() {
     }
 
     /**
-     * A fixed name identifying the error. For errors generated from {@link ServiceException}, this corresponding to the
+     * A fixed name identifying the error. For errors generated from {@link ServiceException}, this corresponds to the
      * {@link ErrorType#name} and is part of the service's API surface. Clients are given access to the service-side
-     * error name via {@link RemoteException#getError} and typically switch&dispatch on the error code and/or name.
+     * error name via {@link RemoteException#getError} and typically switch and dispatch on the error code and/or name.
      */
     @JsonProperty("errorName")
     @Value.Default