Skip to content

Commit 1748004

Browse files
committed
Use Member::getTable() instead of string "panichd_members"
1 parent 4ad0dd1 commit 1748004

5 files changed

Lines changed: 23 additions & 18 deletions

File tree

src/Controllers/MembersController.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,18 @@ public function index(Request $request)
3030
*/
3131
public function store(Request $request)
3232
{
33+
$member = new \PanicHDMember;
34+
3335
$rules = [
3436
'name' => 'required',
35-
'email' => 'bail|required|unique:panichd_members|email',
37+
'email' => 'bail|required|unique:' . $member->getTable() . '|email',
3638
'password' => 'required|confirmed',
3739
'password_confirmation' => 'required'
3840
];
3941

4042
$this->validate($request, $rules);
4143

42-
$member = new \PanicHDMember;
44+
4345
$member->name = $request->name;
4446
$member->email = $request->email;
4547
$member->password = bcrypt($request->password);

src/Controllers/TicketsController.php

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ public function __construct(Ticket $tickets, \PanicHDMember $member)
4545
// This is loaded via AJAX at file Views\index.blade.php
4646
public function data($ticketList = 'active')
4747
{
48+
$members_table = (new \PanicHDMember)->getTable();
49+
4850
$datatables = app(\Yajra\Datatables\Datatables::class);
4951

5052
$agent = $this->member->find(auth()->user()->id);
@@ -55,14 +57,14 @@ public function data($ticketList = 'active')
5557
->leftJoin('users', function ($join1){
5658
$join1->on('users.id', '=', 'panichd_tickets.user_id');
5759
})
58-
->leftJoin('panichd_members', function ($join2) {
59-
$join2->on('panichd_members.id', '=', 'panichd_tickets.user_id');
60+
->leftJoin($members_table . ' as members', function ($join2) {
61+
$join2->on('members.id', '=', 'panichd_tickets.user_id');
6062
})
61-
->leftJoin('panichd_members as creator', function ($join3){
63+
->leftJoin($members_table . ' as creator', function ($join3){
6264
$join3->on('creator.id', '=', 'panichd_tickets.creator_id');
6365
})
6466
->join('panichd_statuses', 'panichd_statuses.id', '=', 'panichd_tickets.status_id')
65-
->leftJoin('panichd_members as agent', function ($join4){
67+
->leftJoin($members_table . ' as agent', function ($join4){
6668
$join4->on('agent.id', '=', 'panichd_tickets.agent_id');
6769
})
6870
->join('panichd_priorities', 'panichd_priorities.id', '=', 'panichd_tickets.priority_id')
@@ -108,7 +110,7 @@ public function data($ticketList = 'active')
108110
'agent.name as agent_name',
109111
'panichd_priorities.name AS priority',
110112
'panichd_priorities.magnitude AS priority_magnitude',
111-
'panichd_members.name AS owner_name',
113+
$members_table . '.name AS owner_name',
112114
'creator.name as creator_name',
113115
'panichd_tickets.user_id',
114116
'panichd_tickets.creator_id',
@@ -123,7 +125,7 @@ public function data($ticketList = 'active')
123125
];
124126

125127
if (Setting::grab('departments_feature')){
126-
$collection->leftJoin('panichd_departments', 'panichd_departments.id', '=', 'panichd_members.department_id')
128+
$collection->leftJoin('panichd_departments', 'panichd_departments.id', '=', $members_table . '.department_id')
127129
->leftJoin('panichd_departments as dep_ancestor', 'panichd_departments.department_id', '=', 'dep_ancestor.id');
128130

129131
// Department columns
@@ -772,7 +774,7 @@ protected function validation_common($request, $new_ticket = true)
772774

773775
$fields = [
774776
'subject' => 'required|min:3',
775-
'owner_id' => 'required|exists:panichd_members,id',
777+
'owner_id' => 'required|exists:' . $this->member->getTable() . ',id',
776778
'category_id' => 'required|in:'.$allowed_categories,
777779
'content' => 'required|min:6',
778780
];
@@ -1044,20 +1046,21 @@ public function viewAttachment($attachment_id)
10441046
public function show($id)
10451047
{
10461048
$user = $this->member->find(auth()->user()->id);
1049+
$members_table = $this->member->getTable();
10471050

10481051
$ticket = $this->tickets
10491052
->with('owner')
10501053
->with('creator')
10511054
->with('agent')
10521055
->with('category.closingReasons')
10531056
->with('tags')
1054-
->leftJoin('panichd_members', function($join1){
1055-
$join1->on('panichd_members.id', '=', 'panichd_tickets.user_id');
1057+
->leftJoin($members_table, function($join1) use($members_table){
1058+
$join1->on($members_table . '.id', '=', 'panichd_tickets.user_id');
10561059
})
1057-
->leftJoin('panichd_members as creator', function($join2){
1060+
->leftJoin($members_table . ' as creator', function($join2){
10581061
$join2->on('creator.id', '=', 'panichd_tickets.creator_id');
10591062
})
1060-
->leftJoin('panichd_members as agent', function($join3){
1063+
->leftJoin($members_table . ' as agent', function($join3){
10611064
$join3->on('agent.id', '=', 'panichd_tickets.agent_id');
10621065
});
10631066

@@ -1067,10 +1070,10 @@ public function show($id)
10671070

10681071
$a_select = [
10691072
'panichd_tickets.*',
1070-
'panichd_members.name as owner_name',
1073+
$members_table . '.name as owner_name',
10711074
'creator.name as creator_name',
10721075
'agent.name as agent_name',
1073-
'panichd_members.email as owner_email'
1076+
$members_table . '.email as owner_email'
10741077
];
10751078

10761079
// Select Ticket and properties

src/Translations/ca/admin.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@
175175
// $admin_route_path/member/____
176176
'member-index-title' => 'Gestió d\'usuaris Membres',
177177
'member-index-help' => 'Els membres son tots els usuaris registrats a la base de dades. L\'administrador d\'aquest lloc web pot haver filtrat la llista',
178-
'member-index-empty' => 'No s\'ha trobat usuaris registrats. Si us plau, revisa si hi ha algun error a la vista de la base de dades "panichd_members"',
178+
'member-index-empty' => 'No s\'ha trobat usuaris registrats',
179179
'member-table-own-tickets' => 'Tiquets propis',
180180
'member-table-assigned-tickets' => 'Tiquets assignats',
181181
'member-modal-update-title' => 'Actualitzar membre',

src/Translations/en/admin.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@
176176
// $admin_route_path/member/____
177177
'member-index-title' => 'Members management',
178178
'member-index-help' => 'Members are all registered users in database. This website administrator may have filtered the list',
179-
'member-index-empty' => 'No registered members were found. Please, check if there is any error in database "panichd_members" view',
179+
'member-index-empty' => 'No registered members were found',
180180
'member-table-own-tickets' => 'Own tickets',
181181
'member-table-assigned-tickets' => 'Assigned tickets',
182182
'member-modal-update-title' => 'Update member',

src/Views/tickets/datatable/loader.blade.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
@if( $u->currentLevel() > 1 )
5757
{ data: 'priority', name: 'panichd_priorities.name', "orderData": [1, 3, 4, 5], "orderSequence": ['desc', 'asc']},
5858
@if (session('panichd_filter_owner')=="")
59-
{ data: 'owner_name', name: 'panichd_members.name' },
59+
{ data: 'owner_name', name: '{{ $u->getTable() }}.name' },
6060
@if ($setting::grab('departments_feature'))
6161
{ data: 'dept_full_name', name: 'panichd_departments.name' },
6262
@endif

0 commit comments

Comments
 (0)