Skip to content

Commit 1a402ab

Browse files
xaviqvxaviqv
committed
Load summernote assets when needed only
1 parent 9b71913 commit 1a402ab

7 files changed

Lines changed: 70 additions & 64 deletions

File tree

‎src/PanicHDServiceProvider.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ public function boot()
120120
$view->with(compact('n_notices'));
121121
});
122122

123-
view()->composer('panichd::tickets.partials.summernote', function ($view) {
123+
view()->composer(['panichd::tickets.partials.summernote', 'panichd::shared.summernote'], function ($view) {
124124
$editor_locale = Setting::grab('summernote_locale');
125125

126126
if ($editor_locale == 'laravel') {

‎src/Views/admin/configuration/edit.blade.php‎

Lines changed: 30 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,36 @@
66

77
@include('panichd::shared.common')
88

9+
@include('panichd::shared.summernote')
10+
11+
@section('footer')
12+
<script>
13+
function changeSerialize(e){
14+
document.querySelector("#serialize-password").style.display = e.checked ? 'block' : 'none';
15+
document.querySelector(".help-block").style.display = e.checked ? 'block' : 'none';
16+
}
17+
18+
changeSerialize(document.querySelector("input[name='serialize']"));
19+
</script>
20+
21+
@if($should_serialize)
22+
<script src="{{asset('vendor/panichd/js/codemirror/mode/clike-' . PanicHD\PanicHD\Helpers\Cdn::CodeMirror . '.min.js')}}"></script>
23+
<script src="{{asset('vendor/panichd/js/codemirror/mode/php-' . PanicHD\PanicHD\Helpers\Cdn::CodeMirror . '.min.js')}}"></script>
24+
<script type="text/javascript">
25+
window.addEventListener('load', function(){
26+
CodeMirror.fromTextArea( document.querySelector("textarea[name='value']"), {
27+
lineNumbers: true,
28+
mode: 'text/x-php',
29+
theme: 'monokai',
30+
indentUnit: 2,
31+
lineWrapping: true
32+
});
33+
});
34+
35+
</script>
36+
@endif
37+
@append
38+
939
@section('content')
1040
<div class="card bg-light">
1141
<div class="card-header">
@@ -122,35 +152,4 @@
122152
{!! CollectiveForm::close() !!}
123153
</div>
124154
</div>
125-
126-
<script>
127-
function changeSerialize(e){
128-
document.querySelector("#serialize-password").style.display = e.checked ? 'block' : 'none';
129-
document.querySelector(".help-block").style.display = e.checked ? 'block' : 'none';
130-
}
131-
132-
changeSerialize(document.querySelector("input[name='serialize']"));
133-
134-
135-
</script>
136-
137-
138-
@if($should_serialize)
139-
<script src="{{asset('vendor/panichd/js/codemirror/codemirror-' . PanicHD\PanicHD\Helpers\Cdn::CodeMirror . '.min.js')}}"></script>
140-
<script src="{{asset('vendor/panichd/js/codemirror/mode/clike-' . PanicHD\PanicHD\Helpers\Cdn::CodeMirror . '.min.js')}}"></script>
141-
<script src="{{asset('vendor/panichd/js/codemirror/mode/php-' . PanicHD\PanicHD\Helpers\Cdn::CodeMirror . '.min.js')}}"></script>
142-
<script type="text/javascript">
143-
window.addEventListener('load', function(){
144-
CodeMirror.fromTextArea( document.querySelector("textarea[name='value']"), {
145-
lineNumbers: true,
146-
mode: 'text/x-php',
147-
theme: 'monokai',
148-
indentUnit: 2,
149-
lineWrapping: true
150-
});
151-
});
152-
153-
</script>
154-
@endif
155-
156155
@stop

‎src/Views/shared/assets.blade.php‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,6 @@
33
<link rel="StyleSheet" href="{{asset('vendor/panichd/font-awesome/css/all-5.2.0.min.css')}}">
44
@endif
55

6-
@if($editor_enabled)
7-
<link rel="StyleSheet" href="{{asset('vendor/panichd/css/summernote/summernote-bs4.css')}}">
8-
@if($codemirror_enabled)
9-
<link rel="StyleSheet" href="{{asset('vendor/panichd/css/codemirror/codemirror-' . PanicHD\PanicHD\Helpers\Cdn::CodeMirror . '.min.css')}}">
10-
<link rel="StyleSheet" href="{{asset('vendor/panichd/css/codemirror/codemirror-' . PanicHD\PanicHD\Helpers\Cdn::CodeMirror . '-' . $codemirror_theme . '.min.css')}}">
11-
@endif
12-
@endif
13-
146
<link rel="StyleSheet" href="{{asset('vendor/panichd/css/select2.min.css')}}">
157
<style type="text/css">
168
.select2-selection__choice {

‎src/Views/shared/summernote.blade.php‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
@section('panichd_assets')
2+
@if($editor_enabled)
3+
<link rel="StyleSheet" href="{{asset('vendor/panichd/css/summernote/summernote-bs4.css')}}">
4+
@if($codemirror_enabled)
5+
<link rel="StyleSheet" href="{{asset('vendor/panichd/css/codemirror/codemirror-' . PanicHD\PanicHD\Helpers\Cdn::CodeMirror . '.min.css')}}">
6+
<link rel="StyleSheet" href="{{asset('vendor/panichd/css/codemirror/codemirror-' . PanicHD\PanicHD\Helpers\Cdn::CodeMirror . '-' . $codemirror_theme . '.min.css')}}">
7+
@endif
8+
@endif
9+
@append
10+
11+
@section('footer')
12+
@if($codemirror_enabled)
13+
<script src="{{asset('vendor/panichd/js/codemirror/codemirror-' . PanicHD\PanicHD\Helpers\Cdn::CodeMirror . '.min.js')}}"></script>
14+
@endif
15+
16+
<script src="{{ asset('vendor/panichd/js/summernote/summernote-bs4.min.js') }}"></script>
17+
@if($editor_locale)
18+
<script src="{{ asset('vendor/panichd/js/summernote/lang/summernote-'.$editor_locale.'.js') }}"></script>
19+
@endif
20+
@append

‎src/Views/tickets/createedit.blade.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@
242242
@include('panichd::shared.photoswipe_files')
243243
@include('panichd::shared.datetimepicker')
244244
@include('panichd::shared.jcrop_files')
245+
@include('panichd::tickets.partials.summernote')
245246

246247
@section('footer')
247248
<script type="text/javascript">
@@ -351,7 +352,6 @@
351352
$('#start_date').data("DateTimePicker").maxDate(e.date);
352353
});
353354
});
354-
</script>
355-
@include('panichd::tickets.partials.summernote')
355+
</script>
356356
@include('panichd::tickets.partials.tags_footer_script')
357357
@append

‎src/Views/tickets/partials/summernote.blade.php‎

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,22 @@
11
@if($editor_enabled)
2+
@include('panichd::shared.summernote')
23

3-
@if($codemirror_enabled)
4-
<script src="{{asset('vendor/panichd/js/codemirror/codemirror-' . PanicHD\PanicHD\Helpers\Cdn::CodeMirror . '.min.js')}}"></script>
5-
<script src="{{asset('vendor/panichd/js/codemirror/mode/xml-' . PanicHD\PanicHD\Helpers\Cdn::CodeMirror . '.min.js')}}"></script>
6-
@endif
4+
@section('footer')
5+
<script src="{{asset('vendor/panichd/js/codemirror/mode/xml-' . PanicHD\PanicHD\Helpers\Cdn::CodeMirror . '.min.js')}}"></script>
6+
<script>
7+
var summernote_options = "";
78
8-
<script src="{{ asset('vendor/panichd/js/summernote/summernote-bs4.min.js') }}"></script>
9-
@if($editor_locale)
10-
<script src="{{ asset('vendor/panichd/js/summernote/lang/summernote-'.$editor_locale.'.js') }}"></script>
11-
@endif
9+
$(function() {
1210
13-
<script>
14-
var summernote_options = "";
11+
summernote_options = $.extend(true, {lang: '{{$editor_locale}}' {!! $codemirror_enabled ? ", codemirror: {theme: '{$codemirror_theme}', mode: 'text/html', htmlMode: true, lineWrapping: true}" : '' !!} } , {!! $editor_options !!});
1512
16-
$(function() {
13+
// Usage within HTML Body
14+
$("textarea.summernote-editor").summernote(summernote_options);
1715
18-
summernote_options = $.extend(true, {lang: '{{$editor_locale}}' {!! $codemirror_enabled ? ", codemirror: {theme: '{$codemirror_theme}', mode: 'text/html', htmlMode: true, lineWrapping: true}" : '' !!} } , {!! $editor_options !!});
19-
20-
// Usage within HTML Body
21-
$("textarea.summernote-editor").summernote(summernote_options);
22-
23-
$("label[for=content]").click(function () {
24-
$("#content").summernote("focus");
25-
});
26-
});
27-
</script>
16+
$("label[for=content]").click(function () {
17+
$("#content").summernote("focus");
18+
});
19+
});
20+
</script>
21+
@append
2822
@endif

‎src/Views/tickets/show.blade.php‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,10 @@
3232

3333
@include('panichd::shared.photoswipe_files')
3434
@include('panichd::shared.jcrop_files')
35+
@include('panichd::tickets.partials.summernote')
3536

3637
@section('footer')
3738
@include('panichd::tickets.show.script')
38-
@include('panichd::tickets.partials.summernote')
39+
3940
@include('panichd::tickets.partials.tags_footer_script')
4041
@append

0 commit comments

Comments
 (0)