Skip to content

Commit 5d58c7b

Browse files
committed
Bug: Inactive settings check was returning false if there was a number of DB settings equal of the seeder
1 parent ce276c5 commit 5d58c7b

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/Controllers/InstallController.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -375,13 +375,14 @@ public function inactiveSettings()
375375
}
376376

377377
// Application active migrations
378-
$default_Settings = $seeder->getDefaults();
378+
$seeder_settings = $seeder->getDefaults();
379379

380-
if (count($installed_settings) == count($default_Settings)) {
380+
$inactive_settings = array_diff_key($seeder_settings, $installed_settings);
381+
382+
if (!$inactive_settings) {
381383
return false;
382384
}
383-
384-
$inactive_settings = array_diff_key($default_Settings, $installed_settings);
385+
385386
return $inactive_settings;
386387
}
387388

0 commit comments

Comments
 (0)