Rename agentTotalTickets() relation to ticketsAsAgent()

Author: xaviqv

src/Controllers/DashboardController.php

@@ -39,13 +39,13 @@ public function index($indicator_period = 2)
         }
 
         // Total tickets counter per agent for google pie chart
-        $agents_share_obj = \PanicHDMember::agents()->with(['agentTotalTickets' => function ($query) {
+        $agents_share_obj = \PanicHDMember::agents()->with(['ticketsAsAgent' => function ($query) {
             $query->addSelect(['id', 'agent_id']);
         }])->get();
 
         $agents_share = [];
         foreach ($agents_share_obj as $agent_share) {
-            $agents_share[$agent_share->name] = $agent_share->agentTotalTickets->count();
+            $agents_share[$agent_share->name] = $agent_share->ticketsAsAgent->count();
         }
 
         // Per Agent

src/Controllers/MembersController.php

@@ -15,7 +15,7 @@ class MembersController extends Controller
      */
     public function index(Request $request)
     {
-        $a_members = \PanicHDMember::withCount(['userTickets', 'agentTotalTickets'])->orderBy('name')->get();
+        $a_members = \PanicHDMember::withCount(['userTickets', 'ticketsAsAgent'])->orderBy('name')->get();
 
         return view('panichd::admin.member.index', compact('a_members'));
     }
@@ -93,7 +93,7 @@ public function destroy(Request $request, $id)
             return redirect()->back();
         }
 
-        if ($member->userTickets()->count() > 0 or $member->agentTotalTickets()->count() > 0) {
+        if ($member->userTickets()->count() > 0 or $member->ticketsAsAgent()->count() > 0) {
             \Session::flash('warning', trans('panichd::admin.member-with-tickets-delete'));
 
             return redirect()->back();

src/Models/Member.php

@@ -412,9 +412,9 @@ public function tickets($complete = false)
     }
 
     /**
-     * Get related agent total tickets.
+     * Get related tickets as agent
      */
-    public function agentTotalTickets()
+    public function ticketsAsAgent()
     {
         return $this->hasMany('PanicHD\PanicHD\Models\Ticket', 'agent_id');
     }

src/Models/Ticket.php

@@ -815,7 +815,7 @@ public function scopeCompletedOnYear($query, $year = false)
     public function autoSelectAgent()
     {
         $cat_id = $this->category_id;
-        $agents = Category::find($cat_id)->agents()->wherePivot('autoassign', '1')->with(['agentTotalTickets' => function ($query) {
+        $agents = Category::find($cat_id)->agents()->wherePivot('autoassign', '1')->with(['ticketsAsAgent' => function ($query) {
             $query->addSelect(['id', 'agent_id']);
         }])->get();
         $count = 0;
@@ -825,10 +825,10 @@ public function autoSelectAgent()
         $selected_agent_id = $first_admin->id;
         foreach ($agents as $agent) {
             if ($count == 0) {
-                $lowest_tickets = $agent->agentTotalTickets->count();
+                $lowest_tickets = $agent->ticketsAsAgent->count();
                 $selected_agent_id = $agent->id;
             } else {
-                $tickets_count = $agent->agentTotalTickets->count();
+                $tickets_count = $agent->ticketsAsAgent->count();
                 if ($tickets_count < $lowest_tickets) {
                     $lowest_tickets = $tickets_count;
                     $selected_agent_id = $agent->id;