BUG: complete / reopen comment check was not aware of recent comments from other users

xaviqv · xaviqv · commit a17554032e86 · 2021-02-23T14:07:59.000+01:00
diff --git a/src/Controllers/TicketsController.php b/src/Controllers/TicketsController.php
@@ -2276,7 +2276,7 @@ public function complete(Request $request, $id)
      */
     public function complete_change_actions($ticket, $member, $member_reason = false, $a_clarification = false)
     {
-        $latest = Models\Comment::where('ticket_id', $ticket->id)->where('user_id', $this->member->id)->orderBy('id', 'desc')->first();
+        $latest = Models\Comment::where('ticket_id', $ticket->id)->orderBy('id', 'desc')->first();
 
         if ($latest and in_array($latest->type, ['complete', 'reopen'])) {
             // Delete last comment for consecutive complete-reopen

Original file line number	Diff line number	Diff line change
`@@ -2276,7 +2276,7 @@ public function complete(Request $request, $id)`
`2276`	`2276`	`*/`
`2277`	`2277`	`public function complete_change_actions($ticket, $member, $member_reason = false, $a_clarification = false)`
`2278`	`2278`	`{`
`2279`		`- $latest = Models\Comment::where('ticket_id', $ticket->id)->where('user_id', $this->member->id)->orderBy('id', 'desc')->first();`
	`2279`	`+ $latest = Models\Comment::where('ticket_id', $ticket->id)->orderBy('id', 'desc')->first();`
`2280`	`2280`
`2281`	`2281`	`if ($latest and in_array($latest->type, ['complete', 'reopen'])) {`
`2282`	`2282`	`// Delete last comment for consecutive complete-reopen`