Deleted "include_font_awesome" configuration setting

Author: xaviqv

src/Controllers/ConfigurationsController.php

@@ -30,7 +30,7 @@ public function index()
 		'email.color_button_bg', 'email.account.name', 'email.account.mailbox' ];
 		$tickets_section = ['default_priority_id', 'default_status_id', 'default_close_status_id', 'default_reopen_status_id', 'subject_content_column', 'paginate_items', 'attachments_ticket_max_size', 'attachments_ticket_max_files_num', 'attachments_mimes', 'attachments_path', 'thumbnails_path', 'oldest_year', 'user_route', 'html_replacements'];
 		$perms_section = ['agent_restrict', 'close_ticket_perm', 'reopen_ticket_perm'];
-		$editor_section = ['editor_enabled', 'include_font_awesome', 'editor_html_highlighter', 'codemirror_theme',
+		$editor_section = ['editor_enabled', 'editor_html_highlighter', 'codemirror_theme',
 			'summernote_locale', 'summernote_options_json_file', 'summernote_options_user', 'purifier_config', ];
 
         // Split them into configurations sections for tabs

src/PanicHDServiceProvider.php

@@ -117,12 +117,6 @@ public function boot()
                 $view->with(compact('master', 'email', 'tools', 'editor_enabled', 'codemirror_enabled', 'codemirror_theme'));
             });
 
-            // Include font awesome css or not
-            view()->composer('panichd::shared.assets', function ($view) {
-                $include_font_awesome = Setting::grab('include_font_awesome');
-                $view->with(compact('include_font_awesome'));
-            });
-			
 			// Include $n_notices in shared.nav and tickets.createedit templates
 			view()->composer(['panichd::shared.nav', 'panichd::tickets.createedit'], function ($view) {
 				$n_notices = Setting::grab('departments_notices_feature') ? Ticket::active()->notHidden()->whereIn('user_id', \PanicHDMember::find(auth()->user()->id)->getMyNoticesUsers())->count() : 0;

src/Seeds/SettingsTableSeeder.php

@@ -304,12 +304,6 @@ public function getDefaults()
              */
             'editor_enabled' => 'yes',
 
-            /*
-             * If Font-awesome css is included outside Panic Help Desk, this should be set to 'no'
-             * Default: 'yes'
-             */
-            'include_font_awesome' => 'yes',
-
             /*
              * Which language should summernote js texteditor use
              * If value is 'laravel', locale set in config/app.php will be used

src/Translations/ar/settings.php

@@ -77,15 +77,6 @@
 			</p>
 ENDHTML
 
-    , 'include_font_awesome' => <<<'ENDHTML'
-			<p>If Font-awesome css is included outside Panic Help Desk, this should be set to <code>0</code></p>
-
-			<p>
-				Don't include: <code>0</code><br>
-				Include: <code>1</code>
-			</p>
-ENDHTML
-
     , 'summernote_locale' => <<<"ENDHTML"
 			<p>
 				Which language should summernote js texteditor use<br>

src/Translations/ca/settings.php

@@ -77,15 +77,6 @@
 			</p>
 ENDHTML
 
-    , 'include_font_awesome' => <<<'ENDHTML'
-			<p>If Font-awesome css is included outside Panic Help Desk, this should be set to <code>0</code></p>
-
-			<p>
-				Don't include: <code>0</code><br>
-				Include: <code>1</code>
-			</p>
-ENDHTML
-
     , 'summernote_locale' => <<<'ENDHTML'
 			<p>
 				Which language should summernote js texteditor use<br>

src/Translations/en/settings.php

@@ -77,15 +77,6 @@
 			</p>
 ENDHTML
 
-    , 'include_font_awesome' => <<<'ENDHTML'
-			<p>If Font-awesome css is included outside Panic Help Desk, this should be set to <code>0</code></p>
-
-			<p>
-				Don't include: <code>0</code><br>
-				Include: <code>1</code>
-			</p>
-ENDHTML
-
     , 'summernote_locale' => <<<"ENDHTML"
 			<p>
 				Which language should summernote js texteditor use<br>

src/Translations/es/settings.php

@@ -76,15 +76,6 @@
 			</p>
 ENDHTML
 
-    , 'include_font_awesome' => <<<'ENDHTML'
-			<p>Si Font-awesome css se incluyo fuera de Panic Help Desk, deberías configurar esto como <code>0</code></p>
-
-			<p>
-				No incluir: <code>0</code><br>
-				Incluir: <code>1</code>
-			</p>
-ENDHTML
-
     , 'summernote_locale' => <<<"ENDHTML"
 			<p>
 			    ¿Qué lenguaje debería usar el editor de texto summernote js?<br>

src/Translations/it/settings.php

@@ -77,15 +77,6 @@
 			</p>
 ENDHTML
 
-    , 'include_font_awesome' => <<<'ENDHTML'
-			<p>If Font-awesome css is included outside Panic Help Desk, this should be set to <code>0</code></p>
-
-			<p>
-				Don't include: <code>0</code><br>
-				Include: <code>1</code>
-			</p>
-ENDHTML
-
     , 'summernote_locale' => <<<"ENDHTML"
 			<p>
 				Which language should summernote js texteditor use<br>

src/Translations/ru/settings.php

@@ -112,16 +112,6 @@
 HTML
     ,
 
-    'include_font_awesome' => <<<'HTML'
-			<p>Подключать Font-awesome css. Выставьте <code>0</code>, если он уже используется на страницах</p>
-
-			<p>
-				Не подключать: <code>0</code><br>
-				Подключать: <code>1</code>
-			</p>
-HTML
-    ,
-
     'summernote_locale' => <<<'HTML'
 			<p>
 				Какой язык должен использовать summernote<br>

src/Views/shared/assets.blade.php

@@ -1,8 +1,5 @@
 <link rel="StyleSheet" href="{{asset('vendor/panichd/css/bootstrap/bootstrap-4.1.3.min.css')}}">
-@if($include_font_awesome)
-	<link rel="StyleSheet" href="{{asset('vendor/panichd/font-awesome/css/all-5.2.0.min.css')}}">
-@endif
-
+<link rel="StyleSheet" href="{{asset('vendor/panichd/font-awesome/css/all-5.2.0.min.css')}}">
 <link rel="StyleSheet" href="{{asset('vendor/panichd/css/select2.min.css')}}">
 <style type="text/css">
 .select2-selection__choice {