Skip to content

Commit e3f3ed7

Browse files
committed
Ban user access to hidden ticket for owner only
1 parent e832835 commit e3f3ed7

2 files changed

Lines changed: 2 additions & 6 deletions

File tree

src/Controllers/TicketsController.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1225,10 +1225,6 @@ public function show($id)
12251225
// Select Ticket and properties
12261226
$ticket = $ticket->select($a_select)->findOrFail($id);
12271227

1228-
if ($ticket->hidden and $member->currentLevel() == 1){
1229-
return redirect()->route(Setting::grab('main_route').'.index')->with('warning', trans('panichd::lang.you-are-not-permitted-to-access'));
1230-
}
1231-
12321228
if (version_compare(app()->version(), '5.3.0', '>=')) {
12331229
$a_reasons = $ticket->category->closingReasons()->pluck('text','id')->toArray();
12341230
$a_tags_selected = $ticket->tags()->pluck('id')->toArray();

src/Middleware/UserAccessMiddleware.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ public function handle($request, Closure $next)
3030
$ticket = $this->getRouteTicket($request);
3131

3232
// Ticket Owner has access
33-
if ($member->isTicketOwner($ticket->id)) {
34-
return $next($request);
33+
if ($member->isTicketOwner($ticket->id) and !$ticket->hidden) {
34+
return $next($request);
3535
}
3636

3737
if ($member->isAgent()) {

0 commit comments

Comments
 (0)