New setting use_default_status_id

Author: xaviqv

src/Controllers/ConfigurationsController.php

@@ -30,7 +30,7 @@ public function index()
 		'email.color_button_bg', 'email.account.name', 'email.account.mailbox' ];
 		$tickets_section = ['default_priority_id', 'default_status_id', 'default_close_status_id', 'default_reopen_status_id',
             'subject_content_column', 'paginate_items', 'attachments_ticket_max_size', 'attachments_ticket_max_files_num', 'attachments_mimes',
-            'attachments_path', 'thumbnails_path', 'oldest_year', 'user_route', 'html_replacements', 'list_text_max_length'];
+            'attachments_path', 'thumbnails_path', 'oldest_year', 'user_route', 'html_replacements', 'list_text_max_length', 'use_default_status_id'];
 		$perms_section = ['agent_restrict', 'close_ticket_perm', 'reopen_ticket_perm'];
 		$editor_section = ['editor_enabled', 'editor_html_highlighter', 'codemirror_theme',
 			'summernote_locale', 'summernote_options_json_file', 'summernote_options_user', 'purifier_config', ];

src/Controllers/TicketsController.php

@@ -617,7 +617,10 @@ protected function getCacheList($list)
 				break;
 			case 'statuses':
 				$instance = Cache::remember('panichd::statuses', 60, function () {
-					return Models\Status::all();
+					if (Setting::grab('use_default_status_id')){
+                        return Models\Status::all();
+                    }else
+                        return Models\Status::all()->where('id', '!=', Setting::grab('default_status_id'));
 				});
 				break;
 			default:
@@ -822,6 +825,8 @@ protected function validation_common($request, $new_ticket = true)
 			}
 
 			$fields['status_id'] = 'required|exists:panichd_statuses,id';
+			if (!Setting::grab('use_default_status_id')) $fields['status_id'].= '|not_in:' . Setting::grab('default_status_id');
+
 			$fields['priority_id'] = 'required|exists:panichd_priorities,id';
 
 			if ($request->has('start_date')){

src/Seeds/SettingsTableSeeder.php

@@ -188,16 +188,21 @@ public function getDefaults()
              */
             'default_status_id' => 1,
             /*
-             * The default closing status
+             * The default closing status for tickets
              * Default: false
              */
             'default_close_status_id' => false,
             /*
-             * The default reopening status
+             * The default reopening status for tickets
              * Default: false
              */
             'default_reopen_status_id' => false,
 
+            /*
+             * Define the behavior related to default_status_id. If enabled, it allows to edit a ticket using "Newest" list or the status == default_status_id
+             */
+            'use_default_status_id' => 'yes',
+
             /*
              * [Deprecated] User ids who are members of admin role
              * Default: 1

src/Views/tickets/createedit.blade.php

@@ -89,25 +89,30 @@
 					]) !!}
 					<div class="col-lg-9">
                         <?php
-							$a_lists = [
-								'newest' => [
-									'complete' => 'no',
-									'default_status_id' => $setting->grab('default_status_id')
-								],
-								'active' => [
-									'complete' => 'no',
-									'default_status_id' => $setting->grab('default_reopen_status_id')
-								],
-								'complete' => [
-									'complete' => 'yes',
-									'default_status_id' => $setting->grab('default_close_status_id')
-								]
+							if ($setting->grab('use_default_status_id')){
+							    $a_lists['newest'] = [
+                                    'complete' => 'no',
+                                    'default_status_id' => $setting->grab('default_status_id')
+                                ];
+							}
+
+							$a_lists['active'] = [
+								'complete' => 'no',
+								'default_status_id' => $setting->grab('default_reopen_status_id')
+							];
+							$a_lists['complete'] = [
+								'complete' => 'yes',
+								'default_status_id' => $setting->grab('default_close_status_id')
 							];
 
 							if ($a_current['complete'] == "yes"){
 								$checked_list = 'complete';
 							}elseif($a_current['status_id'] == $setting->grab('default_status_id')){
-								$checked_list = 'newest';
+								if ($setting->grab('use_default_status_id')){
+                                    $checked_list = 'newest';
+								}else{
+                                    $checked_list = 'active';
+								}
 							}else{
 								$checked_list = 'active';
 							}
@@ -321,14 +326,16 @@
 			}
         });
 
-	    // Change in status affects the List only changing from or to default_status_id
-		$('#select_status').change(function(){
-		    if ($(this).val() == '{{ $setting->grab('default_status_id') }}'){
-                if (!$('#radio_newest_list').is(':checked')) $('#radio_newest_list').prop('checked', true).parent().effect('highlight');
-			}else{
-                if ($('#radio_newest_list').is(':checked')) $('#radio_active_list').prop('checked', true).parent().effect('highlight');
-            }
-		});
+	    @if($setting->grab('use_default_status_id'))
+			// Change in status affects the List only changing from or to default_status_id
+			$('#select_status').change(function(){
+				if ($(this).val() == '{{ $setting->grab('default_status_id') }}'){
+					if (!$('#radio_newest_list').is(':checked')) $('#radio_newest_list').prop('checked', true).parent().effect('highlight');
+				}else{
+					if ($('#radio_newest_list').is(':checked')) $('#radio_active_list').prop('checked', true).parent().effect('highlight');
+				}
+			});
+		@endif
 
 	    // Category select with $u->maxLevel() > 1 only
 		$('#category_change').change(function(){