Skip to content

Commit 52b6531

Browse files
authored
ci: get package tag version from binary instead (#1606)
* get package tag version from binary instead * capture output for better debugging instead
1 parent 2dc8048 commit 52b6531

1 file changed

Lines changed: 7 additions & 24 deletions

File tree

build-packages.sh

Lines changed: 7 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -31,30 +31,13 @@ if [ ! -f "dist/$bin" ]; then
3131
exit 1
3232
fi
3333

34-
if [ -z "${FRANKENPHP_VERSION}" ]; then
35-
FRANKENPHP_VERSION="$(git rev-parse --verify HEAD)"
36-
export FRANKENPHP_VERSION
37-
elif [ -d ".git/" ]; then
38-
CURRENT_REF="$(git rev-parse --abbrev-ref HEAD)"
39-
export CURRENT_REF
40-
41-
if echo "${FRANKENPHP_VERSION}" | grep -F -q "."; then
42-
# Tag
43-
44-
# Trim "v" prefix if any
45-
FRANKENPHP_VERSION=${FRANKENPHP_VERSION#v}
46-
export FRANKENPHP_VERSION
47-
48-
git checkout "v${FRANKENPHP_VERSION}"
49-
else
50-
git checkout "${FRANKENPHP_VERSION}"
51-
fi
52-
fi
34+
version_output="$(dist/"$bin" version)"
35+
frankenphp_version=$(echo "$version_output" | grep -oP 'FrankenPHP\s+\K[^ ]+' || true)
5336

54-
if [[ ! "${FRANKENPHP_VERSION}" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
55-
echo "Warning: FRANKENPHP_VERSION must be set to X.Y.Z (e.g. 1.5.1), got '${FRANKENPHP_VERSION}'"
37+
if [[ ! "${frankenphp_version}" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
38+
echo "Warning: frankenphp_version must be set to X.Y.Z (e.g. 1.5.1), got '${frankenphp_version}'"
5639
echo "Falling back to non-release version 0.0.0"
57-
FRANKENPHP_VERSION=0.0.0
40+
frankenphp_version=0.0.0
5841
fi
5942

6043
group_preexists=0
@@ -87,7 +70,7 @@ iteration=1
8770
glibc_version=$(ldd -v "$bin" | awk '/GLIBC_/ {gsub(/[()]/, "", $2); print $2}' | grep -v GLIBC_PRIVATE | sort -V | tail -n1)
8871
cxxabi_version=$(strings "$bin" | grep -oP 'CXXABI_\d+\.\d+(\.\d+)?' | sort -V | tail -n1)
8972

90-
fpm -s dir -t rpm -n frankenphp -v "${FRANKENPHP_VERSION}" \
73+
fpm -s dir -t rpm -n frankenphp -v "${frankenphp_version}" \
9174
--config-files /etc/frankenphp/Caddyfile \
9275
--config-files /etc/frankenphp/php.ini \
9376
--depends "libc.so.6(${glibc_version})(64bit)" \
@@ -110,7 +93,7 @@ fpm -s dir -t rpm -n frankenphp -v "${FRANKENPHP_VERSION}" \
11093
glibc_version=$(ldd -v "$bin" | awk '/GLIBC_/ {gsub(/[()]/, "", $2); print $2}' | grep -v GLIBC_PRIVATE | sed 's/GLIBC_//' | sort -V | tail -n1)
11194
cxxabi_version=$(strings "$bin" | grep -oP 'CXXABI_\d+\.\d+(\.\d+)?' | sed 's/CXXABI_//' | sort -V | tail -n1)
11295

113-
fpm -s dir -t deb -n frankenphp -v "${FRANKENPHP_VERSION}" \
96+
fpm -s dir -t deb -n frankenphp -v "${frankenphp_version}" \
11497
--config-files /etc/frankenphp/Caddyfile \
11598
--config-files /etc/frankenphp/php.ini \
11699
--depends "libc6 (>= ${glibc_version})" \

0 commit comments

Comments
 (0)