Skip to content

Commit 73c7b2e

Browse files
authored
ci: use Powershell 7+ for Windows workflow (#2236)
1 parent 6268015 commit 73c7b2e

1 file changed

Lines changed: 16 additions & 25 deletions

File tree

.github/workflows/windows.yaml

Lines changed: 16 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
---
12
name: Build Windows release
23

34
concurrency:
@@ -8,21 +9,15 @@ on:
89
pull_request:
910
branches:
1011
- main
11-
paths:
12-
- "docker-bake.hcl"
13-
- "vcpkg.json"
14-
- ".github/workflows/static.yaml"
15-
- "**cgo.go"
16-
- "**Dockerfile"
17-
- "**.c"
18-
- "**.h"
19-
- "**.sh"
20-
- "**.stub.php"
12+
paths-ignore:
13+
- "docs/**"
2114
push:
2215
branches:
2316
- main
2417
tags:
2518
- v*.*.*
19+
paths-ignore:
20+
- "docs/**"
2621
workflow_dispatch:
2722
inputs:
2823
#checkov:skip=CKV_GHA_7
@@ -46,10 +41,6 @@ env:
4641
jobs:
4742
build:
4843
runs-on: windows-latest
49-
defaults:
50-
run:
51-
shell: powershell
52-
5344
steps:
5445
- name: Configure Git
5546
run: |
@@ -72,7 +63,7 @@ jobs:
7263
$frankenphpVersion = $env:GITHUB_SHA
7364
}
7465
75-
echo "FRANKENPHP_VERSION=$frankenphpVersion" | Out-File -FilePath $env:GITHUB_ENV -Append
66+
"FRANKENPHP_VERSION=$frankenphpVersion" >> $env:GITHUB_ENV
7667
7768
- name: Setup Go
7869
uses: actions/setup-go@v6
@@ -102,7 +93,7 @@ jobs:
10293

10394
- name: Download PHP
10495
run: |
105-
$webContent = Invoke-WebRequest -Uri $env:PHP_DOWNLOAD_BASE -UseBasicParsing
96+
$webContent = Invoke-WebRequest -Uri $env:PHP_DOWNLOAD_BASE
10697
$links = $webContent.Links.Href | Where-Object { $_ -match "php-\d+\.\d+\.\d+-Win32-vs17-x64\.zip$" }
10798
10899
if (-not $links) { throw "Could not find PHP zip files at $env:PHP_DOWNLOAD_BASE" }
@@ -112,14 +103,14 @@ jobs:
112103
$version = if ($latestFile -match '(\d+\.\d+\.\d+)') { $matches[1] }
113104
Write-Host "Detected latest PHP version: $version"
114105
115-
"PHP_VERSION=$version" | Out-File -FilePath $env:GITHUB_ENV -Append
106+
"PHP_VERSION=$version" >> $env:GITHUB_ENV
116107
117108
$phpZip = "php-$version-Win32-vs17-x64.zip"
118109
$develZip = "php-devel-pack-$version-Win32-vs17-x64.zip"
119110
120111
$dirName = "frankenphp-$env:FRANKENPHP_VERSION-php-$version-Win32-vs17-x64"
121112
122-
echo "DIR_NAME=$dirName" | Out-File -FilePath $env:GITHUB_ENV -Append
113+
"DIR_NAME=$dirName" >> $env:GITHUB_ENV
123114
124115
Invoke-WebRequest -Uri "$env:PHP_DOWNLOAD_BASE/$phpZip" -OutFile "$env:TEMP\php.zip"
125116
Expand-Archive -Path "$env:TEMP\php.zip" -DestinationPath "$env:GITHUB_WORKSPACE\$dirName"
@@ -134,13 +125,13 @@ jobs:
134125
$phpBin = "$env:GITHUB_WORKSPACE\$env:DIR_NAME"
135126
$phpDevel = "$env:GITHUB_WORKSPACE\php-devel\php-$env:PHP_VERSION-devel-vs17-x64"
136127
137-
echo "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\Llvm\bin" | Out-File -FilePath $env:GITHUB_PATH -Append
138-
echo "$vcpkgRoot\bin" | Out-File -FilePath $env:GITHUB_PATH -Append
139-
echo "$watcherRoot" | Out-File -FilePath $env:GITHUB_PATH -Append
140-
echo "$phpBin" | Out-File -FilePath $env:GITHUB_PATH -Append
128+
"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\Llvm\bin" >> $env:GITHUB_PATH
129+
"$vcpkgRoot\bin" >> $env:GITHUB_PATH
130+
"$watcherRoot" >> $env:GITHUB_PATH
131+
"$phpBin" >> $env:GITHUB_PATH
141132
142-
echo "CGO_CFLAGS=-DFRANKENPHP_VERSION=$env:FRANKENPHP_VERSION -I$vcpkgRoot\include -I$watcherRoot -I$phpDevel\include -I$phpDevel\include\main -I$phpDevel\include\TSRM -I$phpDevel\include\Zend -I$phpDevel\include\ext" | Out-File -FilePath $env:GITHUB_ENV -Append
143-
echo "CGO_LDFLAGS=-L$vcpkgRoot\lib -lbrotlienc -L$watcherRoot -llibwatcher-c -L$phpBin -L$phpDevel\lib -lphp8ts -lphp8embed" | Out-File -FilePath $env:GITHUB_ENV -Append
133+
"CGO_CFLAGS=-DFRANKENPHP_VERSION=$env:FRANKENPHP_VERSION -I$vcpkgRoot\include -I$watcherRoot -I$phpDevel\include -I$phpDevel\include\main -I$phpDevel\include\TSRM -I$phpDevel\include\Zend -I$phpDevel\include\ext" >> $env:GITHUB_ENV
134+
"CGO_LDFLAGS=-L$vcpkgRoot\lib -lbrotlienc -L$watcherRoot -llibwatcher-c -L$phpBin -L$phpDevel\lib -lphp8ts -lphp8embed" >> $env:GITHUB_ENV
144135
145136
- name: Embed Windows icon and metadata
146137
working-directory: frankenphp\caddy\frankenphp
@@ -174,7 +165,7 @@ jobs:
174165
Translation = @{ LangID = 9; CharsetID = 1200 }
175166
}
176167
} | ConvertTo-Json -Depth 10
177-
[System.IO.File]::WriteAllText("versioninfo.json", $json, [System.Text.Encoding]::Default)
168+
$json | Set-Content "versioninfo.json"
178169
179170
goversioninfo -64 -icon ..\..\frankenphp.ico versioninfo.json -o resource.syso
180171

0 commit comments

Comments
 (0)