misc(logging): clean up

Author: burgesQ

frankenphp.c

@@ -566,7 +566,7 @@ PHP_FUNCTION(frankenphp_log) {
   ret = go_log_attrs(thread_index, message, message_len, (int)level, context);
   if (ret != NULL) {
     zend_throw_exception(spl_ce_RuntimeException, ret, 0);
-    // free(ret); // NOTE: is the string copied by zend_throw ??
+    free(ret);
     RETURN_THROWS();
   }
 }

frankenphp.go

@@ -693,45 +693,6 @@ func go_log(threadIndex C.uintptr_t, message *C.char, level C.int) {
 	}
 }
 
-// go_log_attrs is a cgo-exported bridge between PHP and the Go slog logger.
-//
-// It is called from C/PHP and must not panic. All errors are reported by
-// returning a C-allocated error string; on success it returns NULL.
-//
-// Parameters:
-//
-// threadIndex:
-//   - Index into the phpThreads table, used to retrieve the Go context for
-//     the current PHP request/thread.
-//
-// message:
-//   - Pointer to a C string containing the log message bytes. The memory
-//     is owned by the caller and must NOT be freed by Go.
-//
-// len:
-//   - Length of the message, in bytes, as seen from C (not including the
-//     terminating NUL). This is passed to C.GoStringN to build the Go string.
-//
-// level:
-//   - Numeric log level compatible with slog.Level values. It is cast to
-//     slog.Level inside this function.
-//
-// cattrs:
-//   - Pointer to a PHP zval representing an associative array of attributes,
-//     or NULL. When non-NULL, it is converted to map[string]any via GoMap[any]
-//     and then mapped to slog.Attr values (using slog.Any under the hood).
-//
-// Return value:
-//
-// On success:
-//   - Returns NULL and the message is logged (if the logger is enabled at
-//     the given level).
-//
-// On error:
-//   - Returns a non-NULL *C.char pointing to a NUL-terminated error message
-//     allocated with C.CString. The caller is responsible for releasing
-//     this memory.
-//
 //export go_log_attrs
 func go_log_attrs(threadIndex C.uintptr_t, message *C.char, len C.int, level C.int, cattrs *C.zval) *C.char {
 	var attrs map[string]any