Skip to content

Commit f36bd51

Browse files
perf(metrics): use WithLabelValues instead (#1450)
* Uses WithMetricLabels instead. * trigger build --------- Co-authored-by: Alliballibaba <alliballibaba@gmail.com>
1 parent 45bba21 commit f36bd51

File tree

1 file changed

+12
-18
lines changed

1 file changed

+12
-18
lines changed

metrics.go

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -97,10 +97,6 @@ type PrometheusMetrics struct {
9797
mu sync.Mutex
9898
}
9999

100-
func (m *PrometheusMetrics) getLabels(name string) prometheus.Labels {
101-
return prometheus.Labels{"worker": name}
102-
}
103-
104100
func (m *PrometheusMetrics) StartWorker(name string) {
105101
m.busyThreads.Inc()
106102

@@ -109,15 +105,15 @@ func (m *PrometheusMetrics) StartWorker(name string) {
109105
return
110106
}
111107

112-
m.totalWorkers.With(m.getLabels(name)).Inc()
108+
m.totalWorkers.WithLabelValues(name).Inc()
113109
}
114110

115111
func (m *PrometheusMetrics) ReadyWorker(name string) {
116112
if m.totalWorkers == nil {
117113
return
118114
}
119115

120-
m.readyWorkers.With(m.getLabels(name)).Inc()
116+
m.readyWorkers.WithLabelValues(name).Inc()
121117
}
122118

123119
func (m *PrometheusMetrics) StopWorker(name string, reason StopReason) {
@@ -128,14 +124,13 @@ func (m *PrometheusMetrics) StopWorker(name string, reason StopReason) {
128124
return
129125
}
130126

131-
metricLabels := m.getLabels(name)
132-
m.totalWorkers.With(metricLabels).Dec()
133-
m.readyWorkers.With(metricLabels).Dec()
127+
m.totalWorkers.WithLabelValues(name).Dec()
128+
m.readyWorkers.WithLabelValues(name).Dec()
134129

135130
if reason == StopReasonCrash {
136-
m.workerCrashes.With(metricLabels).Inc()
131+
m.workerCrashes.WithLabelValues(name).Inc()
137132
} else if reason == StopReasonRestart {
138-
m.workerRestarts.With(metricLabels).Inc()
133+
m.workerRestarts.WithLabelValues(name).Inc()
139134
}
140135
}
141136

@@ -262,31 +257,30 @@ func (m *PrometheusMetrics) StopWorkerRequest(name string, duration time.Duratio
262257
return
263258
}
264259

265-
metricLabels := m.getLabels(name)
266-
m.workerRequestCount.With(metricLabels).Inc()
267-
m.busyWorkers.With(metricLabels).Dec()
268-
m.workerRequestTime.With(metricLabels).Add(duration.Seconds())
260+
m.workerRequestCount.WithLabelValues(name).Inc()
261+
m.busyWorkers.WithLabelValues(name).Dec()
262+
m.workerRequestTime.WithLabelValues(name).Add(duration.Seconds())
269263
}
270264

271265
func (m *PrometheusMetrics) StartWorkerRequest(name string) {
272266
if m.busyWorkers == nil {
273267
return
274268
}
275-
m.busyWorkers.With(m.getLabels(name)).Inc()
269+
m.busyWorkers.WithLabelValues(name).Inc()
276270
}
277271

278272
func (m *PrometheusMetrics) QueuedWorkerRequest(name string) {
279273
if m.workerQueueDepth == nil {
280274
return
281275
}
282-
m.workerQueueDepth.With(m.getLabels(name)).Inc()
276+
m.workerQueueDepth.WithLabelValues(name).Inc()
283277
}
284278

285279
func (m *PrometheusMetrics) DequeuedWorkerRequest(name string) {
286280
if m.workerQueueDepth == nil {
287281
return
288282
}
289-
m.workerQueueDepth.With(m.getLabels(name)).Dec()
283+
m.workerQueueDepth.WithLabelValues(name).Dec()
290284
}
291285

292286
func (m *PrometheusMetrics) QueuedRequest() {

0 commit comments

Comments
 (0)