Skip to content

Commit 33ad612

Browse files
authored
Remove update to BPF map not used in status quo tls tracing (#1298)
Summary: Remove update to BPF map not used in status quo tls tracing In order to vet the new style of tls tracing, we introduced a mechanism for detecting mismatched fds (#1161). This instrumented all of our tls tracing when it was first developed. When the new method of tls tracing was introduced, we removed the mismatched fd detection from the status quo tls tracing (#1123), however, this BPF map update was missed in that refactor (#1123). Relevant Issues: #692 Type of change: /kind bug Test Plan: Existing tests pass Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
1 parent 456d9e1 commit 33ad612

1 file changed

Lines changed: 0 additions & 10 deletions

File tree

src/stirling/source_connectors/socket_tracer/bcc_bpf/openssl_trace.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -147,11 +147,6 @@ int probe_entry_SSL_write(struct pt_regs* ctx) {
147147
void* ssl = (void*)PT_REGS_PARM1(ctx);
148148
update_node_ssl_tls_wrap_map(ssl);
149149

150-
struct nested_syscall_fd_t nested_syscall_fd = {
151-
.fd = kInvalidFD,
152-
};
153-
ssl_user_space_call_map.update(&id, &nested_syscall_fd);
154-
155150
char* buf = (char*)PT_REGS_PARM2(ctx);
156151
int32_t fd = get_fd(tgid, ssl);
157152

@@ -192,11 +187,6 @@ int probe_entry_SSL_read(struct pt_regs* ctx) {
192187
void* ssl = (void*)PT_REGS_PARM1(ctx);
193188
update_node_ssl_tls_wrap_map(ssl);
194189

195-
struct nested_syscall_fd_t nested_syscall_fd = {
196-
.fd = kInvalidFD,
197-
};
198-
ssl_user_space_call_map.update(&id, &nested_syscall_fd);
199-
200190
char* buf = (char*)PT_REGS_PARM2(ctx);
201191
int32_t fd = get_fd(tgid, ssl);
202192

0 commit comments

Comments
 (0)