Commit d15c088
Don't count Cypress as embedding
Summary:
Cypress puts the application under test in an iframe. It tries to mask this, but doesn't do a perfect job and our embed detection happened to notice.
This makes an exception to the rule by explicitly checking for Cypress.
I tried having it also check that the parent frame has a Cypress-specific location (so that we can detect if we're in a nested frame for actual embed tests), but Cypress fakes the top URL so we can't detect that difference.
Test Plan: Run normally. Test that embed still behave as they should. Cypress should now load again (it was broken).
Reviewers: michelle, vihang
Reviewed By: michelle
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
Differential Revision: https://phab.corp.pixielabs.ai/D11699
GitOrigin-RevId: 5db68c71 parent 05a0098 commit d15c088
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
27 | 30 | | |
28 | 31 | | |
29 | 32 | | |
| |||
0 commit comments