Skip to content

Commit f0036c2

Browse files
[build-and-test] Remove custom name from matrix checks. (#1316)
Summary: When there are no matrix configs to run, without this change, a check is added with an ugly ${{ matrix.name }}. This PR removes the custom naming, which removes the ugly ${{matrix.name}} Type of change: /kind cleanup Test Plan: Testing with this PR, since there shouldn't be any matrix configs to run. Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
1 parent b22ac71 commit f0036c2

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

.github/workflows/build_and_test.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,10 @@ jobs:
8686
- /etc/bazelrc:/etc/bazelrc
8787
- /var/run/docker.sock:/var/run/docker.sock
8888
options: --privileged
89-
if: needs.generate-matrix.outputs.matrix
89+
if: ${{ needs.generate-matrix.outputs.matrix && (toJson(fromJson(needs.generate-matrix.outputs.matrix)) != '[]') }}
9090
strategy:
9191
matrix: ${{ fromJson(needs.generate-matrix.outputs.matrix) }}
9292
fail-fast: false
93-
name: ${{ matrix.name }}
9493
steps:
9594
- uses: actions/checkout@8f4b7f84864484a7bf31766abe9204da3cbe65b3 # v3.5.0
9695
- name: Add pwd to git safe dir

0 commit comments

Comments
 (0)