Merge pull request #25 from learn-co-curriculum/edit-tests-and-readme

edited readme for accuracy on Capybara, uppercased Submit in tests

Author: maxwellbenton

README.md

@@ -3,7 +3,7 @@
 ## Overview
 
 In this lab, you'll practice building forms in Sinatra by creating a basketball
-team sign-up sheet. Your application will have a basic html form, and will
+team sign-up sheet. Your application will have a basic HTML form, and will
 display the data from the form after it has been submitted by the user.
 
 ## Instructions
@@ -15,24 +15,26 @@ display the data from the form after it has been submitted by the user.
 3. Make a form
 
    Create a route that responds to a GET request at `/newteam`.
-   Add a form to the `newteam.erb` template and render it in the GET `/newteam` route.
+   Add a form to the `newteam.erb` template and render it in the GET `/newteam`
+   route.
+
    The form should have fields for:
-    Team name ('name')
-    Coach ('coach')
-    Point Guard ('pg')
-    Shooting Guard ('sg')
-    Power Forward ('pf')
-    Small Forward ('sf')
-    Center ('c')
+   Team name ('name')
+   Coach ('coach')
+   Point Guard ('pg')
+   Shooting Guard ('sg')
+   Power Forward ('pf')
+   Small Forward ('sf')
+   Center ('c')
 
-  It should look something like this:
+It should look something like this:
 
-  ![form for basketball team](https://curriculum-content.s3.amazonaws.com/web-development/Sinatra/basketball-form.png)
+![form for basketball team](https://curriculum-content.s3.amazonaws.com/web-development/Sinatra/basketball-form.png)
 
-  When creating your form, your "Submit" button will need to be identified by
-  either an `id` attribute or a `name` attribute with value of "Submit". We're
-  telling this to you now because our test frame work, Capybara, requires buttons
-  to be [findable either by an `id` or `name` attribute][capybara-click_button].
+When creating your form, your "Submit" button will need to be identified by an
+`id` attribute attribute with value of "Submit". We're telling this to you now
+because our test frame work, Capybara, requires buttons to be
+[findable by an `id`, `title`, or `value` attribute][capybara-click_button].
 
 4. Handle form submission
 
@@ -42,22 +44,23 @@ display the data from the form after it has been submitted by the user.
 
 5. Final Output
 
-   Update the `team.erb` template so when you post to this form, it displays the name of the team and each member of the team.
+   Update the `team.erb` template so when you post to this form, it displays
+   the name of the team and each member of the team.
 
    Your view should display something like this:
 
    ![completed form](https://curriculum-content.s3.amazonaws.com/web-development/Sinatra/basketball-results.png)
 
 6. Deliverables
 
-  Pass the tests! Make sure you read the test output carefully!
+Pass the tests! Make sure you read the test output carefully!
 
 ## Resources
 
 * [Ashley William's GitHub](https://github.com/ashleygwilliams/) - [Sinatra Form Party](https://github.com/ashleygwilliams/sinatra-form-party)
 
 * [Ashley William's GitHub](https://github.com/ashleygwilliams/) - [Citibike Sinatra](https://github.com/ashleygwilliams/citibike-sinatra)
 
-<p data-visibility='hidden'>View <a href='https://learn.co/lessons/basic-sinatra-forms-lab' title='Sinatara Forms Lab'>Sinatara Forms Lab</a> on Learn.co and start learning to code for free.</p>
-
 [capybara-click_button]: http://www.rubydoc.info/gems/capybara/Capybara%2FNode%2FActions%3Aclick_button
+
+<p data-visibility='hidden'>View <a href='https://learn.co/lessons/basic-sinatra-forms-lab' title='Sinatara Forms Lab'>Sinatara Forms Lab</a> on Learn.co and start learning to code for free.</p>

spec/basic_sinatra_forms_spec.rb

@@ -6,7 +6,7 @@
       expect(last_response.status).to eq(200)
     end
 
-    it 'renders basketball team form' do 
+    it 'renders basketball team form' do
       visit '/newteam'
       expect(page).to have_selector("form")
       expect(page).to have_field(:name)
@@ -23,23 +23,23 @@
     it 'does not return Sinatra error page' do
       visit '/newteam'
 
-      click_button "submit"
+      click_button "Submit"
       expect(page).to_not have_text("Backtrace")
     end
 
-    it "displays the basketball team name in the browser" do 
+    it "displays the basketball team name in the browser" do
       visit '/newteam'
 
       fill_in(:name, :with => "Bballers")
-      click_button "submit"
+      click_button "Submit"
       expect(page).to have_text("Team Name: Bballers")
     end
 
     it "displays the coach's name in the browser" do
       visit '/newteam'
 
       fill_in(:coach, :with => "Walter")
-      click_button "submit"
+      click_button "Submit"
 
       expect(page).to have_text("Coach: Walter")
     end
@@ -48,7 +48,7 @@
       visit '/newteam'
 
       fill_in(:pg, :with => "Jeff")
-      click_button "submit"
+      click_button "Submit"
 
       expect(page).to have_text("Point Guard: Jeff")
     end
@@ -57,7 +57,7 @@
       visit '/newteam'
 
       fill_in(:sg, :with => "Ralph")
-      click_button "submit"
+      click_button "Submit"
 
       expect(page).to have_text("Shooting Guard: Ralph")
     end
@@ -66,7 +66,7 @@
       visit '/newteam'
 
       fill_in(:pf, :with => "Danny")
-      click_button "submit"
+      click_button "Submit"
 
       expect(page).to have_text("Power Forward: Danny")
     end
@@ -75,7 +75,7 @@
       visit '/newteam'
 
       fill_in(:sg, :with => "Joe")
-      click_button "submit"
+      click_button "Submit"
 
       expect(page).to have_text("Shooting Guard: Joe")
     end
@@ -84,7 +84,7 @@
       visit '/newteam'
 
       fill_in(:c, :with => "Avi")
-      click_button "submit"
+      click_button "Submit"
 
       expect(page).to have_text("Center: Avi")
     end