Skip to content

Commit 9461e01

Browse files
committed
Improve faiman_rad test and completes get_cell_temperature doc.
1 parent 402b53c commit 9461e01

2 files changed

Lines changed: 10 additions & 7 deletions

File tree

pvlib/pvsystem.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,8 @@ def get_cell_temperature(self, poa_global, temp_air, wind_speed, model,
431431
432432
model : str
433433
Supported models include ``'sapm'``, ``'pvsyst'``,
434-
``'faiman'``, ``'fuentes'``, and ``'noct_sam'``
434+
``'faiman'``, ``'faiman_rad'``, ``'fuentes'``, ``'noct_sam'``,
435+
and ``'ross'``
435436
436437
effective_irradiance : numeric or tuple of numeric, optional
437438
The irradiance that is converted to photocurrent in W/m^2.
@@ -1236,8 +1237,9 @@ def get_cell_temperature(self, poa_global, temp_air, wind_speed, model,
12361237
See Also
12371238
--------
12381239
pvlib.temperature.sapm_cell, pvlib.temperature.pvsyst_cell,
1239-
pvlib.temperature.faiman, pvlib.temperature.fuentes,
1240-
pvlib.temperature.noct_sam
1240+
pvlib.temperature.faiman, pvlib.temperature.faiman_rad,
1241+
pvlib.temperature.fuentes, pvlib.temperature.noct_sam,
1242+
pvlib.temperature.ross
12411243
12421244
Notes
12431245
-----

tests/test_pvsystem.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -495,9 +495,10 @@ def test_PVSystem_faiman_celltemp(mocker):
495495

496496

497497
def test_PVSystem_faiman_rad_celltemp(mocker):
498-
# default values (need to account for a certain ir_down and adjust u0, u1)
499-
ir_down = None
500-
u0, u1 = 25.0, 6.84
498+
ir_down = 50 # arbitrary value
499+
# default values, u0 and u1 being adjusted in same proportion as in
500+
# https://www.osti.gov/servlets/purl/1884890/ (not suggested, just example)
501+
u0,u1 = 25.0*0.86, 6.84*0.88
501502
sky_view = 1.0
502503
emissivity = 0.88
503504

@@ -512,7 +513,7 @@ def test_PVSystem_faiman_rad_celltemp(mocker):
512513
temperature.faiman_rad.assert_called_once_with(irrads, temps, winds,
513514
ir_down, u0, u1,
514515
sky_view, emissivity)
515-
assert_allclose(out, 56.4, atol=1e-1)
516+
assert_allclose(out, 48.6, atol=1e-1)
516517

517518

518519
def test_PVSystem_ross_celltemp(mocker):

0 commit comments

Comments
 (0)