Skip to content

Commit a720411

Browse files
Apply suggestions from code review
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
1 parent 99e3ae9 commit a720411

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

pvlib/pvsystem.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2499,7 +2499,10 @@ def singlediode(photocurrent, saturation_current, resistance_series,
24992499
method : str, default 'lambertw'
25002500
Determines the method used to calculate points on the IV curve. The
25012501
options are ``'lambertw'``, ``'newton'``, ``'brentq'``, or
2502-
``'chandrupatla'`` (requires scipy 1.15 or greater).
2502+
``'chandrupatla'``.
2503+
2504+
.. note::
2505+
``'chandrupatla'`` requires scipy 1.15 or greater.
25032506
25042507
Returns
25052508
-------

pvlib/singlediode.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ def bishop88_i_from_v(voltage, photocurrent, saturation_current,
249249
Keyword arguments passed to root finder method. See
250250
:py:func:`scipy:scipy.optimize.brentq`,
251251
:py:func:`scipy:scipy.optimize.newton`, and
252-
:py:func:`scipy:scipy.optimize.elementwise.find_root` for parameters.
252+
:py:func:`scipy:scipy.optimize.elementwise.find_root` (when ``method='chandrupatla'``) for parameters.
253253
``'full_output': True`` is allowed, and ``optimizer_output`` would be
254254
returned. See examples section.
255255
@@ -502,7 +502,7 @@ def vd_from_brent(voc, i, iph, isat, rs, rsh, gamma, d2mutau, NsVbi,
502502
except ModuleNotFoundError as e:
503503
# TODO remove this when our minimum scipy version is >=1.15
504504
msg = (
505-
"method='chandrupatla' requires scipy v1.15 or greater. "
505+
"method='chandrupatla' requires scipy v1.15 or greater (available for Python3.10+). "
506506
"Select another method, or update your version of scipy. "
507507
f"({str(e)})"
508508
)

0 commit comments

Comments
 (0)