Skip to content

Commit bd1ff4f

Browse files
authored
Apply suggestions from code review
1 parent c958abf commit bd1ff4f

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

pvlib/spectrum/mismatch.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -739,12 +739,11 @@ def spectral_factor_polo(precipitable_water, airmass_absolute, aod500, aoi,
739739
* ``'monosi'`` - anonymous monocrystalline silicon module.
740740
* ``'cigs'`` - anonymous copper indium gallium selenide module.
741741
* ``'asi'`` - anonymous amorphous silicon module.
742-
albedo : float, optional
743-
Ground albedo (default value 0.2). See :term:`albedo`. [unitless]
744-
745742
coefficients : array-like, optional
746743
user-defined coefficients, if not using one of the coefficient
747744
sets via the ``module_type`` parameter.
745+
albedo : float, optional
746+
Ground albedo (default value 0.2). See :term:`albedo`. [unitless]
748747
749748
Returns
750749
-------
@@ -765,15 +764,15 @@ def spectral_factor_polo(precipitable_water, airmass_absolute, aod500, aoi,
765764
if module_type is not None and coefficients is not None:
766765
raise ValueError('Only one of `module_type` and `coefficients` should '
767766
'be provided')
768-
am_aoi = pvlib.atmosphere.get_relative_airmass(aoi)
769767
pressure = pvlib.atmosphere.alt2pres(altitude)
770-
f_aoi_rel= pvlib.atmosphere.get_relative_airmass(aoi, model='kastenyoung1989')
768+
f_aoi_rel = pvlib.atmosphere.get_relative_airmass(aoi,
769+
model='kastenyoung1989')
771770
f_aoi = pvlib.atmosphere.get_absolute_airmass(f_aoi_rel, pressure)
772771
Ram = f_aoi / airmass_absolute
773772
_coefficients = {
774773
'cdte': (-0.0009, 46.80, 49.20, -0.87, 0.00041, 0.053),
775-
'monosi': (0.0027, 10.34, 9.48, 0.307, 0.00077, 0.006),
776-
'cigs': (0.0017, 2.33, 1.30, 0.11, 0.00098, -0.0177),
774+
'monosi': (0.0027, 10.34, 9.48, 0.31, 0.00077, 0.006),
775+
'cigs': (0.0017, 2.33, 1.30, 0.11, 0.00098, -0.018),
777776
'asi': (0.0024, 7.32, 7.09, -0.72, -0.0013, 0.089),
778777
}
779778
c = {

0 commit comments

Comments
 (0)