Always request a draw on a resize & bump patch version (#188)

Author: almarklein

rendercanvas/_version.py

@@ -22,7 +22,7 @@
 
 # This is the base version number, to be bumped before each release.
 # The build system detects this definition when building a distribution.
-__version__ = "2.6.1"
+__version__ = "2.6.2"
 
 # Set this to your library name
 project_name = "rendercanvas"

rendercanvas/base.py

@@ -640,6 +640,8 @@ def _set_visible(self, visible: bool):
         This is meant for the backend to automatically enable/disable
         the rendering when the canvas is e.g. minimized or otherwise invisible.
         If not visible, frames are not rendered, but events are still processed.
+
+        Setting the visibility implicitly requests a new draw.
         """
         if self.__scheduler is not None:
             self.__scheduler.set_enabled(visible)

rendercanvas/core/scheduler.py

@@ -164,6 +164,10 @@ async def __scheduler_task(self):
             if (canvas := self.get_canvas()) is None:
                 break
 
+            # A resize should always draw.
+            if not do_draw:
+                do_draw = canvas._size_info["changed"]
+
             if do_draw:
                 # We do a draw and wait for the full draw to complete, including
                 # the presentation (i.e. the 'consumption' of the frame), using

rendercanvas/glfw.py

@@ -390,11 +390,9 @@ def _on_pixelratio_change(self, *args):
             self._determine_size()
         finally:
             self._changing_pixel_ratio = False
-        self.request_draw()
 
     def _on_size_change(self, *args):
         self._determine_size()
-        self.request_draw()
         # During a resize, the glfw.poll_events() function blocks, so
         # our event-loop is on pause. However, glfw still sends resize
         # events, and we can use these to draw, to get a smoother

rendercanvas/jupyter.py

@@ -115,7 +115,6 @@ def handle_event(self, event):
             pwidth = int(logical_size[0] * pixel_ratio)
             pheight = int(logical_size[1] * pixel_ratio)
             self._size_info.set_physical_size(pwidth, pheight, pixel_ratio)
-            self.request_draw()
             return
 
         # Only submit events that rendercanvas knows. Otherwise, if new events are added

rendercanvas/stub.py

@@ -68,10 +68,11 @@ class StubRenderCanvas(BaseRenderCanvas):
     Backends must call ``self._final_canvas_init()`` at the end of its
     ``__init__()``. This will set the canvas' logical size and title.
 
-    Backends must call ``self._size_info.set_physical_size(width, height, native_pixel_ratio)``,
-    whenever the size or pixel ratio changes. It must be called when the actual
-    viewport has changed, so typically not in ``_rc_set_logical_size()``, but
-    e.g. when the underlying GUI layer fires a resize event.
+    Backends must call ``self._size_info.set_physical_size(width, height,
+    native_pixel_ratio)``, whenever the size or pixel ratio changes. It must be
+    called when the actual viewport has changed, so typically not in
+    ``_rc_set_logical_size()``, but e.g. when the underlying GUI layer fires a
+    resize event. Setting the size implicitly requests a new draw.
 
     Backends must also call ``self.submit_event()``, if applicable, to produce
     events for mouse and keyboard. Backends must *not* submit a "resize" event;