Skip to content

Commit f264a60

Browse files
authored
revert: prevent default (#1010)
* revert: prevent default * test: update test case
1 parent 49a1639 commit f264a60

2 files changed

Lines changed: 11 additions & 4 deletions

File tree

src/hooks/useDrag.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ function useDrag(
108108

109109
const onStartMove: OnStartMove = (e, valueIndex, startValues?: number[]) => {
110110
e.stopPropagation();
111-
e.preventDefault();
112111

113112
// 如果是点击 track 触发的,需要传入变化后的初始值,而不能直接用 rawValues
114113
const initialValues = startValues || rawValues;

tests/Range.test.tsx

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,12 @@ describe('Range', () => {
2525
resetWarned();
2626
});
2727

28-
function doMouseDown(container: HTMLElement, start: number, element = 'rc-slider-handle') {
28+
function doMouseDown(
29+
container: HTMLElement,
30+
start: number,
31+
element = 'rc-slider-handle',
32+
skipEventCheck = false,
33+
) {
2934
const ele = container.getElementsByClassName(element)[0];
3035
const mouseDown = createEvent.mouseDown(ele);
3136
(mouseDown as any).pageX = start;
@@ -42,7 +47,10 @@ describe('Range', () => {
4247
fireEvent.mouseEnter(ele);
4348
fireEvent(ele, mouseDown);
4449

45-
expect(preventDefault).toHaveBeenCalled();
50+
// Should not prevent default since focus will not change
51+
if (!skipEventCheck) {
52+
expect(preventDefault).not.toHaveBeenCalled();
53+
}
4654
}
4755

4856
function doMouseMove(
@@ -635,7 +643,7 @@ describe('Range', () => {
635643
/>,
636644
);
637645

638-
doMouseDown(container, 50, 'rc-slider');
646+
doMouseDown(container, 50, 'rc-slider', true);
639647

640648
expect(onChange).toHaveBeenCalledWith([0, 50, 100]);
641649
});

0 commit comments

Comments
 (0)