Skip to content

Commit 45f4fed

Browse files
authored
Fix Ruby find_min implementation (#49)
Fix the pure Ruby implementation of `find_min`. Since this method is overridden by a method in the C extension, there is no actual harm. ```rb require_relative "lib/enumerable_statistics/array_ext.rb" p [3, 1, 2].find_min ``` Before ```console /home/kojix2/Ruby/enumerable-statistics/lib/enumerable_statistics/array_ext.rb:25:in 'EnumerableStatistics::ArrayExtension#find_min': undefined local variable or method 'imax' for an instance of Array (NameError) imin = i if self[i] < self[imax] ^^^^ Did you mean? max from (irb):2:in '<main>' from /home/kojix2/.local/share/mise/installs/ruby/4.0.1/lib/ruby/gems/4.0.0/gems/irb-1.17.0/exe/irb:9:in '<top (required)>' from /home/kojix2/.local/share/mise/installs/ruby/4.0.1/lib/ruby/4.0.0/rubygems.rb:303:in 'Kernel#load' from /home/kojix2/.local/share/mise/installs/ruby/4.0.1/lib/ruby/4.0.0/rubygems.rb:303:in 'Gem.activate_and_load_bin_path' from /home/kojix2/.local/share/mise/installs/ruby/4.0.1/bin/irb:25:in '<main>' ``` After ```console => [1, 1] ```
1 parent fedb301 commit 45f4fed

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

lib/enumerable_statistics/array_ext.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def find_min
2222

2323
imin, i = 0, 1
2424
while i < n
25-
imin = i if self[i] < self[imax]
25+
imin = i if self[i] < self[imin]
2626
i += 1
2727
end
2828
[self[imin], imin]

0 commit comments

Comments
 (0)