test: remove wait-for-expect dependency and refactor tests (#111)

Author: chenjiahan

package.json

@@ -88,7 +88,6 @@
     "sockjs-client": "^1.6.1",
     "style-loader": "^4.0.0",
     "typescript": "^5.9.3",
-    "wait-for-expect": "^3.0.2",
     "webpack": "^5.105.3",
     "webpack-dev-middleware": "^7.4.5",
     "webpack-merge": "^6.0.1"

pnpm-lock.yaml

@@ -2,7 +2,6 @@ const path = require('node:path');
 const fs = require('node:fs');
 const { rspack } = require('@rspack/core');
 const { RspackDevServer: Server } = require('@rspack/dev-server');
-const waitForExpect = require('wait-for-expect');
 const config = require('../fixtures/overlay-config/webpack.config');
 const trustedTypesConfig = require('../fixtures/overlay-config/trusted-types.webpack.config');
 const runBrowser = require('../helpers/run-browser');
@@ -386,9 +385,12 @@ describe('overlay', () => {
         hidden: true,
       });
 
-      await waitForExpect(async () => {
-        pageHtml = await page.evaluate(() => document.body.outerHTML);
-      });
+      await expect
+        .poll(async () => {
+          pageHtml = await page.evaluate(() => document.body.outerHTML);
+          return pageHtml;
+        })
+        .toBeTypeOf('string');
       overlayHandle = await page.$('#rspack-dev-server-client-overlay');
 
       expect(overlayHandle).toBe(null);
@@ -636,9 +638,7 @@ describe('overlay', () => {
 
       await errorHandle.click();
 
-      await waitForExpect(() => {
-        expect(mockLaunchEditorCb).toHaveBeenCalledTimes(1);
-      });
+      await expect.poll(() => mockLaunchEditorCb.mock.calls.length).toBe(1);
     } finally {
       fs.writeFileSync(pathToFile, originalCode);
       await browser.close();