Skip to content

Commit 1f88ea6

Browse files
committed
Switch to danger-pr-comment for PR checks
Replace ruby-grape-danger with danger-pr-comment to align with the grape repo's two-workflow approach: one workflow runs Danger, another posts the results as PR comments.
1 parent 2ec5246 commit 1f88ea6

4 files changed

Lines changed: 30 additions & 2 deletions

File tree

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
name: Danger Comment
2+
3+
on:
4+
workflow_run:
5+
workflows: [Danger]
6+
types: [completed]
7+
8+
jobs:
9+
comment:
10+
uses: numbata/danger-pr-comment/.github/workflows/danger-comment.yml@v0.1.0
11+
secrets: inherit

.github/workflows/danger.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
name: Danger
2+
3+
on:
4+
pull_request:
5+
types: [opened, reopened, edited, synchronize]
6+
7+
jobs:
8+
danger:
9+
uses: numbata/danger-pr-comment/.github/workflows/danger-run.yml@v0.1.0
10+
secrets: inherit
11+
with:
12+
ruby-version: '3.4'
13+
bundler-cache: true

Dangerfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
# frozen_string_literal: true
22

3-
danger.import_dangerfile(gem: 'ruby-grape-danger')
3+
danger.import_dangerfile(gem: 'danger-pr-comment')
4+
5+
changelog.check!

Gemfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ group :test do
2323
gem 'guard-bundler'
2424
gem 'guard-rspec'
2525
gem 'rb-fsevent'
26-
gem 'ruby-grape-danger', '~> 0.2', require: false
26+
gem 'danger', require: false
27+
gem 'danger-changelog', require: false
28+
gem 'danger-pr-comment', require: false
2729
gem 'simplecov', require: false
2830
end

0 commit comments

Comments
 (0)