chore(storage): Migrate to google-cloud-pubsub v3.x (googleapis#30773)

Author: aandreassa

google-cloud-storage/OVERVIEW.md

@@ -531,14 +531,23 @@ created and owns the topic.)
 require "google/cloud/pubsub"
 require "google/cloud/storage"
 
-pubsub = Google::Cloud::Pubsub.new
+pubsub = Google::Cloud::PubSub.new
 storage = Google::Cloud::Storage.new
 
-topic = pubsub.create_topic "my-topic"
-topic.policy do |p|
-  p.add "roles/pubsub.publisher",
-        "serviceAccount:#{storage.service_account_email}"
-end
+topic_admin = pubsub.topic_admin
+topic_path = pubsub.topic_path "my-topic"
+topic = topic_admin.create_topic name: topic_path
+
+policy = {
+  bindings: [
+    {
+      role: "roles/pubsub.publisher",
+      members: ["serviceAccount:#{storage.service_account_email}"]
+    }
+  ]
+}
+
+pubsub.iam.set_iam_policy resource: topic_path, policy: policy
 
 bucket = storage.bucket "my-bucket"
 

google-cloud-storage/acceptance/storage/bucket_notification_test.rb

@@ -29,11 +29,21 @@
   let(:payload) { "NONE" }
 
   it "creates a Pub/Sub subscription notification" do
+    pubsub = Google::Cloud::PubSub.new
+    topic_admin = pubsub.topic_admin
+    topic = nil
     begin
-      topic = Google::Cloud.pubsub.create_topic topic_name
-      topic.policy do |p|
-        p.add "roles/pubsub.publisher", project_email
-      end
+      topic = topic_admin.create_topic name: pubsub.topic_path(topic_name)
+
+      policy = {
+        bindings: [
+          {
+            role: "roles/pubsub.publisher",
+            members: [project_email]
+          }
+        ]
+      }
+      pubsub.iam.set_iam_policy resource: topic.name, policy: policy
 
       notification = bucket.create_notification topic.name, custom_attrs: custom_attrs,
                                                             event_types: event_types,
@@ -63,8 +73,7 @@
       fresh_notification.delete
     ensure
       bucket.notifications.map(&:delete)
-      post_topic = Google::Cloud.pubsub.topic "#{prefix}_bucket_notification_topic"
-      post_topic.delete if post_topic # Assume no subscriptions to clean up.
+      topic_admin.delete_topic topic: topic.name if topic
     end
   end
 end

google-cloud-storage/acceptance/storage/bucket_requester_pays_test.rb

@@ -122,11 +122,21 @@
   end
 
   it "creates a Pub/Sub subscription notification" do
+    pubsub = Google::Cloud::PubSub.new
+    topic_admin = pubsub.topic_admin
+    topic = nil
     begin
-      topic = Google::Cloud.pubsub.create_topic topic_name
-      topic.policy do |p|
-        p.add "roles/pubsub.publisher", project_email
-      end
+      topic = topic_admin.create_topic name: pubsub.topic_path(topic_name)
+      
+      policy = {
+        bindings: [
+          {
+            role: "roles/pubsub.publisher",
+            members: [project_email]
+          }
+        ]
+      }
+      pubsub.iam.set_iam_policy resource: topic.name, policy: policy
 
       notification = bucket.create_notification topic.name, custom_attrs: custom_attrs,
                                                             event_types: event_types,
@@ -156,8 +166,7 @@
       fresh_notification.delete
     ensure
       bucket.notifications.map(&:delete)
-      post_topic = Google::Cloud.pubsub.topic "#{prefix}_bucket_notification_topic"
-      post_topic.delete if post_topic # Assume no subscriptions to clean up.
+      topic_admin.delete_topic topic: topic.name if topic
     end
   end
 

google-cloud-storage/samples/acceptance/notification_test.rb

@@ -26,17 +26,24 @@
 
   before :all do
     @bucket = create_bucket_helper random_bucket_name
-    pubsub = Google::Cloud::Pubsub.new
-    @topic = pubsub.create_topic random_topic_name
-    topic.policy do |p|
-      p.add "roles/pubsub.publisher",
-            "serviceAccount:#{storage_client.service_account_email}"
-    end
+    pubsub = Google::Cloud::PubSub.new
+    @topic_admin = pubsub.topic_admin
+    @topic = @topic_admin.create_topic name: pubsub.topic_path(random_topic_name)
+
+    policy = {
+      bindings: [
+        {
+          role: "roles/pubsub.publisher",
+          members: ["serviceAccount:#{storage_client.service_account_email}"]
+        }
+      ]
+    }
+    pubsub.iam.set_iam_policy resource: @topic.name, policy: policy
   end
 
   after :all do
     delete_bucket_helper @bucket.name
-    topic.delete
+    @topic_admin.delete_topic topic: @topic.name if @topic
   end
 
   describe "Notification Lifecycle" do