Skip to content

Commit 97c4d73

Browse files
authored
tests(storage): Fix some new rubocop failures (googleapis#30764)
1 parent b053bba commit 97c4d73

2 files changed

Lines changed: 14 additions & 14 deletions

File tree

  • google-cloud-storage/lib/google/cloud/storage

google-cloud-storage/lib/google/cloud/storage/bucket/acl.rb

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ def self.predefined_rule_for rule_name
352352
def auth! if_metageneration_match: nil
353353
update_predefined_acl! "authenticatedRead", if_metageneration_match: if_metageneration_match
354354
end
355-
alias authenticatedRead! auth!
355+
alias authenticatedRead! auth! # rubocop:disable Naming/MethodName
356356
alias auth_read! auth!
357357
alias authenticated! auth!
358358
alias authenticated_read! auth!
@@ -390,7 +390,7 @@ def private! if_metageneration_match: nil
390390
def project_private! if_metageneration_match: nil
391391
update_predefined_acl! "projectPrivate", if_metageneration_match: if_metageneration_match
392392
end
393-
alias projectPrivate! project_private!
393+
alias projectPrivate! project_private! # rubocop:disable Naming/MethodName
394394

395395
##
396396
# Convenience method to apply the `publicRead` predefined ACL
@@ -408,7 +408,7 @@ def project_private! if_metageneration_match: nil
408408
def public! if_metageneration_match: nil
409409
update_predefined_acl! "publicRead", if_metageneration_match: if_metageneration_match
410410
end
411-
alias publicRead! public!
411+
alias publicRead! public! # rubocop:disable Naming/MethodName
412412
alias public_read! public!
413413

414414
# Convenience method to apply the `publicReadWrite` predefined ACL
@@ -426,7 +426,7 @@ def public! if_metageneration_match: nil
426426
def public_write! if_metageneration_match: nil
427427
update_predefined_acl! "publicReadWrite", if_metageneration_match: if_metageneration_match
428428
end
429-
alias publicReadWrite! public_write!
429+
alias publicReadWrite! public_write! # rubocop:disable Naming/MethodName
430430

431431
protected
432432

@@ -718,7 +718,7 @@ def self.predefined_rule_for rule_name
718718
def auth! if_metageneration_match: nil
719719
update_predefined_default_acl! "authenticatedRead", if_metageneration_match: if_metageneration_match
720720
end
721-
alias authenticatedRead! auth!
721+
alias authenticatedRead! auth! # rubocop:disable Naming/MethodName
722722
alias auth_read! auth!
723723
alias authenticated! auth!
724724
alias authenticated_read! auth!
@@ -739,7 +739,7 @@ def auth! if_metageneration_match: nil
739739
def owner_full! if_metageneration_match: nil
740740
update_predefined_default_acl! "bucketOwnerFullControl", if_metageneration_match: if_metageneration_match
741741
end
742-
alias bucketOwnerFullControl! owner_full!
742+
alias bucketOwnerFullControl! owner_full! # rubocop:disable Naming/MethodName
743743

744744
##
745745
# Convenience method to apply the default `bucketOwnerRead`
@@ -757,7 +757,7 @@ def owner_full! if_metageneration_match: nil
757757
def owner_read! if_metageneration_match: nil
758758
update_predefined_default_acl! "bucketOwnerRead", if_metageneration_match: if_metageneration_match
759759
end
760-
alias bucketOwnerRead! owner_read!
760+
alias bucketOwnerRead! owner_read! # rubocop:disable Naming/MethodName
761761

762762
##
763763
# Convenience method to apply the default `private`
@@ -792,7 +792,7 @@ def private! if_metageneration_match: nil
792792
def project_private! if_metageneration_match: nil
793793
update_predefined_default_acl! "projectPrivate", if_metageneration_match: if_metageneration_match
794794
end
795-
alias projectPrivate! project_private!
795+
alias projectPrivate! project_private! # rubocop:disable Naming/MethodName
796796

797797
##
798798
# Convenience method to apply the default `publicRead`
@@ -810,7 +810,7 @@ def project_private! if_metageneration_match: nil
810810
def public! if_metageneration_match: nil
811811
update_predefined_default_acl! "publicRead", if_metageneration_match: if_metageneration_match
812812
end
813-
alias publicRead! public!
813+
alias publicRead! public! # rubocop:disable Naming/MethodName
814814
alias public_read! public!
815815

816816
protected

google-cloud-storage/lib/google/cloud/storage/file/acl.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ def auth! generation: nil,
335335
if_metageneration_match: if_metageneration_match,
336336
if_metageneration_not_match: if_metageneration_not_match
337337
end
338-
alias authenticatedRead! auth!
338+
alias authenticatedRead! auth! # rubocop:disable Naming/MethodName
339339
alias auth_read! auth!
340340
alias authenticated! auth!
341341
alias authenticated_read! auth!
@@ -382,7 +382,7 @@ def owner_full! generation: nil,
382382
if_metageneration_match: if_metageneration_match,
383383
if_metageneration_not_match: if_metageneration_not_match
384384
end
385-
alias bucketOwnerFullControl! owner_full!
385+
alias bucketOwnerFullControl! owner_full! # rubocop:disable Naming/MethodName
386386

387387
##
388388
# Convenience method to apply the `bucketOwnerRead` predefined ACL
@@ -426,7 +426,7 @@ def owner_read! generation: nil,
426426
if_metageneration_match: if_metageneration_match,
427427
if_metageneration_not_match: if_metageneration_not_match
428428
end
429-
alias bucketOwnerRead! owner_read!
429+
alias bucketOwnerRead! owner_read! # rubocop:disable Naming/MethodName
430430

431431
##
432432
# Convenience method to apply the `private` predefined ACL
@@ -513,7 +513,7 @@ def project_private! generation: nil,
513513
if_metageneration_match: if_metageneration_match,
514514
if_metageneration_not_match: if_metageneration_not_match
515515
end
516-
alias projectPrivate! project_private!
516+
alias projectPrivate! project_private! # rubocop:disable Naming/MethodName
517517

518518
##
519519
# Convenience method to apply the `publicRead` predefined ACL
@@ -557,7 +557,7 @@ def public! generation: nil,
557557
if_metageneration_match: if_metageneration_match,
558558
if_metageneration_not_match: if_metageneration_not_match
559559
end
560-
alias publicRead! public!
560+
alias publicRead! public! # rubocop:disable Naming/MethodName
561561
alias public_read! public!
562562

563563
protected

0 commit comments

Comments
 (0)