Skip to content

在多处缺少分页校验,可能造成超大分页查询,进而导致DoS漏洞 #252

@CoupleFuzz

Description

@CoupleFuzz

描述

例如在NewsControllerindex方法中,入参含有用于分页查询的参数limit,然而没有校验这个limit的最大大小,可能造成超大分页查询,进而导致DoS漏洞(CWE-400)。

相关代码片段

    @RequestMapping(value = "", method = RequestMethod.GET)
    public String index(@RequestParam(required = false, defaultValue = "1", value = "page") int page,
                        @RequestParam(required = false, defaultValue = "orders", value = "sort") String sort,
                        @RequestParam(required = false, defaultValue = "desc", value = "order") String order,
                        HttpServletRequest request,
                        Model model) {
...
List<CmsArticle> articles = cmsArticleService.selectByExampleForOffsetPage(cmsArticleExample, (page - 1) * rows, rows);
}

建议修复

添加注解

@Min(value = 1)  @Max(value = 100) int limit,

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions