Snowflake: Support IDENTIFIER for GRANT ROLE (apache#1957)

Author: yoavcloud

src/ast/mod.rs

@@ -6683,7 +6683,7 @@ pub enum Action {
     Replicate,
     ResolveAll,
     Role {
-        role: Ident,
+        role: ObjectName,
     },
     Select {
         columns: Option<Vec<Ident>>,

src/parser/mod.rs

@@ -14389,7 +14389,7 @@ impl<'a> Parser<'a> {
         } else if self.parse_keyword(Keyword::REPLICATE) {
             Ok(Action::Replicate)
         } else if self.parse_keyword(Keyword::ROLE) {
-            let role = self.parse_identifier()?;
+            let role = self.parse_object_name(false)?;
             Ok(Action::Role { role })
         } else if self.parse_keyword(Keyword::SELECT) {
             Ok(Action::Select {

tests/sqlparser_common.rs

@@ -9550,6 +9550,8 @@ fn parse_grant() {
     verified_stmt("GRANT SELECT ON FUTURE SEQUENCES IN SCHEMA db1.sc1 TO ROLE role1");
     verified_stmt("GRANT USAGE ON PROCEDURE db1.sc1.foo(INT) TO ROLE role1");
     verified_stmt("GRANT USAGE ON FUNCTION db1.sc1.foo(INT) TO ROLE role1");
+    verified_stmt("GRANT ROLE role1 TO ROLE role2");
+    verified_stmt("GRANT ROLE role1 TO USER user");
 }
 
 #[test]

tests/sqlparser_snowflake.rs

@@ -4519,4 +4519,7 @@ fn test_snowflake_identifier_function() {
             .is_err(),
         true
     );
+
+    snowflake().verified_stmt("GRANT ROLE IDENTIFIER('AAA') TO USER IDENTIFIER('AAA')");
+    snowflake().verified_stmt("REVOKE ROLE IDENTIFIER('AAA') FROM USER IDENTIFIER('AAA')");
 }