bq: double quoted string

Author: donhcd

src/ast/value.rs

@@ -27,6 +27,8 @@ pub enum Value {
     Number(BigDecimal),
     /// 'string value'
     SingleQuotedString(String),
+    /// "string value"
+    DoubleQuotedString(String),
     /// r'string value'
     RegexLiteral { value: String, quote: char },
     /// N'string value'
@@ -63,7 +65,8 @@ impl fmt::Display for Value {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         match self {
             Value::Number(v) => write!(f, "{}", v),
-            Value::SingleQuotedString(v) => write!(f, "'{}'", escape_single_quote_string(v)),
+            Value::SingleQuotedString(v) => write!(f, "'{}'", v),
+            Value::DoubleQuotedString(v) => write!(f, "\"{}\"", v),
             Value::RegexLiteral { ref value, quote } => write!(f, "{}{}{}", quote, value, quote),
             Value::NationalStringLiteral(v) => write!(f, "N'{}'", v),
             Value::HexStringLiteral(v) => write!(f, "X'{}'", v),

src/parser.rs

@@ -276,6 +276,7 @@ impl<'a> Parser<'a> {
                 value: w.clone(),
                 quote_style: Some('`'),
             }),
+            Token::DoubleQuotedString(s) => Ok(Expr::Value(Value::DoubleQuotedString(s))),
             Token::BqRegexQuotedString { value, quote } => {
                 Ok(Expr::Value(Value::RegexLiteral { value, quote }))
             }

src/tokenizer.rs

@@ -44,6 +44,10 @@ pub enum Token {
     /// This should retains the escaped character sequences so that
     /// .to_string() of the value will give the value that was in the input
     SingleQuotedString(String),
+    /// Double quoted string: i.e: "string"
+    /// This should retains the escaped character sequences so that
+    /// .to_string() of the value will give the value that was in the input
+    DoubleQuotedString(String),
     /// Single quoted string: i.e: 'string'
     BacktickQuotedString(String),
     BqRegexQuotedString {
@@ -165,6 +169,7 @@ impl fmt::Display for Token {
             Token::Number(ref n) => f.write_str(n),
             Token::Char(ref c) => write!(f, "{}", c),
             Token::SingleQuotedString(ref s) => write!(f, "'{}'", s),
+            Token::DoubleQuotedString(ref s) => write!(f, "\"{}\"", s),
             Token::BacktickQuotedString(ref s) => write!(f, "`{}`", s),
             Token::NationalStringLiteral(ref s) => write!(f, "N'{}'", s),
             Token::BqRegexQuotedString { ref value, quote } => {
@@ -353,6 +358,7 @@ impl<'a> Tokenizer<'a> {
                 Token::Word(w) if w.quote_style != None => self.col += w.value.len() as u64 + 2,
                 Token::Number(s) => self.col += s.len() as u64,
                 Token::SingleQuotedString(s) => self.col += s.len() as u64,
+                Token::DoubleQuotedString(s) => self.col += s.len() as u64,
                 Token::BacktickQuotedString(s) => self.col += s.len() as u64,
                 _ => self.col += 1,
             }
@@ -443,6 +449,11 @@ impl<'a> Tokenizer<'a> {
                     Ok(Some(Token::SingleQuotedString(s)))
                 }
                 // string
+                '"' if dialect_of!(self is BigQueryDialect) => {
+                    let s = self.tokenize_double_quoted_string(chars)?;
+                    Ok(Some(Token::DoubleQuotedString(s)))
+                }
+                // string
                 '`' if dialect_of!(self is BigQueryDialect) => {
                     chars.next(); // consume opening backtick
                     let s = peeking_take_while(chars, |ch| ch != '`');